Alex Nemeth authored Sep 22, 2018 and Nate Graham committed Sep 22, 2018

Summary:
Having only one icon in the whole menu seemed a waste of space.
Adding a lock icon to the lock function greatly improves the scene.

Test Plan:
Before:
{F6277876}

After:
{F6277875}

Reviewers: ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: abetts, safaalfulaij, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15683

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Harald Sitter authored Sep 14, 2018 and Eike Hein committed Sep 14, 2018

Summary:
this broke somewhat recently. the new availabletranslationsmodel's
rowcount is always 0 on a completely fresh system with no language
preference set. this is because the actual available languages list is
only compiled in its ::setSelectedLanguages function. this function was
however never called. this resulted in the kcm thinking there are no
available languages and thus making it impossible to actually add one by
disabling the button and having an empty view even if the button wasn't
disabled.

previously this was a single model, from what I can see, and that was
incorrectly ported. where previously the setSelectedLanguages was only
called on one model we now need to call it on all models to properly
propagate the language information.

(the reason it works this way is because available languages kinda need to
 include already selected languages for consistency; even when the kcm
 technically didn't find them available)

Test Plan:
- make new user
- start kcm
- kcm DOES NOT show infobox 'no languages installed' and the add languages button is enabled
- clicking the button gives a list of languages
- adding one works as well

Reviewers: sitter

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15115

GIT_SILENT

Summary:
This fixes the issue when menu transparency is enabled in the Breeze widget settings the context menu of desktop icons have no transparency.
Multiple users (including me) have reported that D14174 did not solve the problem.

BUG: 395262

Test Plan:
Before:
{F6253280}

After:
{F6253279}

Reviewers: hein, davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15435

Summary:
Similar to evdev backend we need to ignore touchpad devices explicitly in the
libinput backend because these are also pointer devices.

XInput2 can do this in theory via input classes, but my touchpad did not set
the class correctly. So just switch to using XInput like in the evdev backend
to query all pointer devices and then use the XI_TOUCHPAD atom to filter out
touchpads.

BUG: 395401
BUG: 395722
BUG: 396269

Test Plan: Manually

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: acrouthamel, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15256

When no label is displayed, there's no point in creating a KFilePlacesModel.
Also, only emit a change for displayLabel when it actually changed.
Moreover, listen to changes in the KFilePlacesModel and update the label if needed.
Also, make the KFilePlacesModel static and shared between all Folder View instances.

Differential Revision: https://phabricator.kde.org/D14426

Folder View is meant to use desktop:/ and having two entries that behave differently can generate confusion.

CCBUG: 398141

Differential Revision: https://phabricator.kde.org/D15331

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Kicker already makes sure the first search result is highlighted
and actionable while searching. This patch makes arrow-down after
typing move to the second search result instead of merely moving
focus from the search field to the list, so the user doesn't have
to press arrow-down twice anymore.

It also allows using arrow-left/right to jump to the other result
columns, when the cursor is at the start or end of the text field,
respectively.

BUG:397779

Reviewers: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15286

Folder View is built on the assumption that actions can only be triggered from the context menu.
This isn't true as keyboard shortcuts can trigger actions which will only get their correct state just before the menu opens.
Moreover, often the action itself isn't disabled/hidden but just not added to the menu, which means it can still be triggered
using a keyboard shortcut.

This patch changes the context menu to always include all (most of them, anyway) actions but instead have updateActions() disable
or hide them as needed.

Also, take into account KFileItemListProperties for more actions (e.g. Cut, Paste, Rename, Trash, …) like Dolphin does it.

Differential Revision: https://phabricator.kde.org/D15162

Disallows moving desktop icons, basically force-enables the "positions locked" option

Differential Revision: https://phabricator.kde.org/D15160

This avoids creating a QDateTime object with all the timezone processing that comes with it since we're only interested
in the relative order, not absolute precise date time values.

CHANGELOG: Sorting files by date in Folder View is significantly faster now

Differential Revision: https://phabricator.kde.org/D15291

apply changes from [Icon KCM] Port to new design https://phabricator.kde.org/D12459

Differential Revision: https://phabricator.kde.org/D15024

There's all sorts of icon view options in the context menu, so add a quick toggle for Previews like Dolphin has it.

Differential Revision: https://phabricator.kde.org/D15269

Rather than a hardcoded list of only two thumbnailers.
All of this is done under the hood so the QML part doesn't need to be changed.
This is the same behavior as Dolphin uses, when the list of thumbnailers is empty, the default set (which includes all thumbnailers
except textthumbs) is used.

CHANGELOG: Folder View now enables previews for most file types by default

Differential Revision: https://phabricator.kde.org/D15268

Summary:
This is not a hard requirement so if a distribution is using older
versions then it won't have the feature, but it also won't crash.

CCBUG: 391468

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15263

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

QT_MIN_VERSIONS is Qt 5.11 for Plasma 5.14. Agreed at kickoff meeting.  Set everywhere for clearity and consistency.

Summary:
Most Plasma widgets and apps that have search fields show them by default. Two exceptions are Kickoff and Widget Explorer (for background, see D15011#315779).

Kickoff is being addressed in D15011. That would leave Widget Explorer as the only case in Plasma (that I could find) where a search field invisibly has keyboard focus and appears when you start typing, but is not actually visible until then. This patch changes that by making the search field always visible, matching everything else in Plasma.

Thanks to @sharvey for doing most of the work already to move the Search Field to its own row in the layout. This patch simply makes it always visible and removes the {nav Search} button that shows and hides it.

Test Plan: {F6218550}

Reviewers: sharvey, #vdg, abetts, #plasma, davidedmundson

Reviewed By: sharvey, #vdg, abetts, #plasma, davidedmundson

Subscribers: abetts, sharvey, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15101

Summary:
Move search to its own row to prevent it from being compressed

BUG: 393427

Test Plan:
- Recompile `plasma-desktop`
- Bring up Widget Explorer
- Press {nav Search} to see Search in new row
- Select widget type category to see Title become elided

Reviewers: ngraham, davidedmundson, #plasma

Reviewed By: ngraham, davidedmundson, #plasma

Subscribers: abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12855

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Plasma-integration's KHintsSettings keeps kdeglobals open, so we need to explicitly sync()
before we go through the process of telling everything it's changed

Differential Revision: https://phabricator.kde.org/D14672

Makes it consistent with other places where such an entry exists, such as Dolphin's context menu

Differential Revision: https://phabricator.kde.org/D15018