1. 21 Oct, 2021 1 commit
    • Alexander Lohnau's avatar
      Remove defunct check for proxyAction in foldermodel · b0831510
      Alexander Lohnau authored and Nate Graham's avatar Nate Graham committed
      If we press the shortcut directly on the desktop the proxy action is still the del action,
      because the context menu was not opened and the selection did not change after we pressed shift.
      
      If we have the context menu open the proxyAction is properly updated.
      
      TestPlan:
      Pressing delete with selected fle opens "Move to trash" dialog
      Pressing shift+delete with selected file opens "Delete Permanently" dialog
      
      Same with the context menu open.
      
      BUG: 444128
      
      
      (cherry picked from commit 2a7c1c73)
      b0831510
  2. 19 Oct, 2021 2 commits
    • Fabio Bas's avatar
      Desktop as folder: restore functionality of the "delete" action · 9f53bf16
      Fabio Bas authored and Nate Graham's avatar Nate Graham committed
      MR552 introduced RemoveAction but broke functionality of the "delete" action
      when both the "trash" and "delete" actions are shown in the menu by requiring
      the "shift" key being pressed for the action to work.
      
      BUG: 442765
      
      
      (cherry picked from commit b893a37f)
      9f53bf16
    • Derek Christ's avatar
      Fix create-folder-shortcut (F10) · d7bcf6de
      Derek Christ authored and Nate Graham's avatar Nate Graham committed
      The create folder shortcut worked as long as the user did not right-
      click into an empty space on the desktop to invoke the context menu.
      
      The problem was that the create-folder-action was set to not visible
      so that it is not shown in the context menu. But as soon as the context
      menu is opened, the action is set to not visible in the plasmoid
      contextual action list. The reason it works before opening the menu is
      because the action for the plasmoid is created without setting it to
      not visible.
      
      This commit fixes the bug by using an already existing workaround class
      that uses an event filter to respond to the
      KStandardShortcut::createFolder key sequence.
      
      BUG: 443512
      
      
      (cherry picked from commit 12350fb1)
      d7bcf6de
  3. 04 Oct, 2021 1 commit
    • David Redondo's avatar
      Open context menu under the cursor again · e36a72c2
      David Redondo authored and Nate Graham's avatar Nate Graham committed
      QMenu::popup() takes a global position but we still want, the
      new file position in local coordinates.
      Tested both that the menu opens correctly and new files are created
      at the correct position which triggered the introduction of setMenuPos.
      BUG:443278
      
      
      (cherry picked from commit 96067c0f)
      e36a72c2
  4. 15 Sep, 2021 1 commit
  5. 09 Sep, 2021 1 commit
    • Derek Christ's avatar
      Introduce RemoveAction for context menu · f830ceea
      Derek Christ authored
      The RemoveAction can either represent the delete action or the move to
      trash action, depending on the shift modifier state.
      This inplace swapping instead of adding and removing both actions fixes
      a visual glitch that could be noticed by pressing and releasing the
      shift key multiple times.
      
      BUG: 438930
      FIXED-IN: 5.22
      f830ceea
  6. 03 Sep, 2021 1 commit
  7. 18 Jul, 2021 1 commit
    • Derek Christ's avatar
      Fix shift-action modifier in context menu · 1b9b49b9
      Derek Christ authored and Nate Graham's avatar Nate Graham committed
      Before this patch, the shift-action modifier in context menus did not
      work when a sub-context menu is open, that does not have the main
      context menu as its parent.
      The new fix installs an event filter on QApplication whenever a new
      context menu is opened to make the context menu aware of shift-presses
      even when a sub-context menu is in focus.
      
      BUG: 425997
      FIXED-IN: 5.22
      
      
      (cherry picked from commit 48ecda47)
      1b9b49b9
  8. 25 Jun, 2021 1 commit
  9. 13 May, 2021 1 commit
  10. 30 Apr, 2021 1 commit
  11. 28 Apr, 2021 1 commit
  12. 27 Apr, 2021 1 commit
  13. 23 Apr, 2021 3 commits
  14. 05 Apr, 2021 1 commit
    • Ahmad Samir's avatar
      General code clean-up · 0b6588c4
      Ahmad Samir authored
      - Less implicit cast from ASCII
      - Use Q_SIGNALS/Q_SLOTS in header files
      - Remove a redundant cmake var
      0b6588c4
  15. 21 Jan, 2021 1 commit
    • Alexander Lohnau's avatar
      Run clang-format · bd3c925d
      Alexander Lohnau authored
      If you want git blame to ignore formatting revisions run:
      git config blame.ignoreRevsFile .git-blame-ignore-revs
      bd3c925d
  16. 18 Jan, 2021 1 commit
  17. 10 Dec, 2020 1 commit
  18. 25 Nov, 2020 1 commit
  19. 23 Oct, 2020 1 commit
  20. 18 Oct, 2020 1 commit
  21. 10 Sep, 2020 1 commit
  22. 09 Sep, 2020 1 commit
  23. 14 Aug, 2020 1 commit
  24. 23 May, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      --warnings · b1c3af20
      Aleix Pol Gonzalez authored
      Port away from some deprecated Qt constructions.
      Mark arguments as unused, remove unused variables.
      Properly sort constructors
      b1c3af20
  25. 04 Feb, 2020 1 commit
  26. 20 Dec, 2019 1 commit
  27. 13 Nov, 2019 1 commit
  28. 24 Oct, 2019 1 commit
  29. 04 Sep, 2019 1 commit
  30. 27 Aug, 2019 1 commit
  31. 31 Jul, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      Remove some uses on QDesktopWidget · a8efa865
      Aleix Pol Gonzalez authored
      Summary: Adds an unnecessary dependency to QtWidgets and forces some round-trips to the X server that we don't need.
      
      Test Plan: Been using it for some days
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22738
      a8efa865
  32. 05 May, 2019 1 commit
  33. 02 Apr, 2019 1 commit
    • Oleg Solovyov's avatar
      foldermodel: store information about screen used · dcb4c158
      Oleg Solovyov authored and Eike Hein's avatar Eike Hein committed
      Summary:
      BUG: 401464
      
      According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not associated with a screen.
      In case of m_screen == -1 there was no information about which items we should filter out.
      
      Instead, we do not change m_screen to -1 and we can filter out items that does not belong to our screen.
      m_screenUsed shows whether folderview is associated with a screen or not
      
      Reviewers: broulik, hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18979
      dcb4c158
  34. 12 Mar, 2019 1 commit
  35. 11 Feb, 2019 1 commit
  36. 01 Feb, 2019 1 commit
    • Eike Hein's avatar
      Fix new file creation leading to dupe items on a fresh view · 4a3fbf91
      Eike Hein authored
      Summary:
      This was a regression caused by the code attempting to insert new items
      at drop position, if available. `setSortMode` was being called in a slot
      connected to the dir model's rowsInserted, but the Positioner has to be
      initialized earlier as a proxy needs to handle
      `sourceRowsAboutToBeInserted` as well.
      
      Thanks to an investigation and patch by Oleg Solovyov in D17689 for
      helping to get to the bottom of this.
      
      This is aimed at 5.12+.
      
      BUG:401023
      
      Reviewers: #plasma, McPain, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: ngraham, davidedmundson, fvogt, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18182
      4a3fbf91
  37. 15 Dec, 2018 1 commit