1. 02 Dec, 2018 1 commit
  2. 29 Nov, 2018 6 commits
    • Nate Graham's avatar
      Merge branch 'Plasma/5.14' · 05c011ff
      Nate Graham authored
      05c011ff
    • Nate Graham's avatar
      Merge branch 'Plasma/5.12' into Plasma/5.14 · 78da28e7
      Nate Graham authored
      78da28e7
    • Nate Graham's avatar
      [Folder View] implement a minimum width for icon view to ensure that labels... · 0b654afd
      Nate Graham authored
      [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless
      
      Summary:
      Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.
      
      This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.
      
      BUG: 379432
      FIXED-IN: 5.12.8
      
      Test Plan:
      Smallest size, before: {F6426124}
      Smallest size, after: {F6426126}
      Equal padding on either side of the container itself still works: {F6426129}
      
      There is no change for sizes corresponding to the fourth tick on the slider and beyond
      
      Reviewers: #plasma, #vdg, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: abetts, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16901
      0b654afd
    • Marco Martin's avatar
      Port applet/containment configs to qqc2 · c2640f83
      Marco Martin authored
      Summary:
      port the applet config dialogs and containments to
      QtQuickControls2 and Kirigami modernizing it,
      using form layouts, Headings and inline messages.
      look is almost the same modulo fixing some misalignments and following
      the hig more closely
      
      BUG: 401472
      FIXED-IN: 5.15.0
      
      Test Plan:
      looked at every wallpaper plugin and
      loaded the config dialog of many applets
      
      Reviewers: #plasma, #vdg, broulik, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: abetts, ngraham, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17211
      c2640f83
    • Laurent Montel's avatar
      Use isEmpty here too · 2460a8aa
      Laurent Montel authored
      2460a8aa
    • Laurent Montel's avatar
      d47b207b
  3. 28 Nov, 2018 4 commits
  4. 27 Nov, 2018 7 commits
    • Jonathan Riddell's avatar
      Update version number for 5.14.4 · 2f2cb30b
      Jonathan Riddell authored
      GIT_SILENT
      2f2cb30b
    • Nate Graham's avatar
      Merge branch 'Plasma/5.14' · 002809f9
      Nate Graham authored
      002809f9
    • Nate Graham's avatar
      Merge branch 'Plasma/5.12' into Plasma/5.14 · 9a5d0a1f
      Nate Graham authored
      9a5d0a1f
    • Nate Graham's avatar
      [Folder View] improve label contrast against challenging backgrounds · 10278e79
      Nate Graham authored
      Summary:
      Currently the shadow behind Folder View items' labels is very subtle. This leads to poor contrast against wallpapers that are light-colored, visually busy, or both.
      
      This patch attempts to improve the situation by tightening up the shadow so that it looks more like a subtle, tasteful outline.
      
      BUG: 361228
      FIXED-IN: 5.12.8
      
      Test Plan:
      Folder View items against various wallpapers:
      {F6439459, size="full"}
      
      {F6439458, size="full"}
      
      {F6439463, size="full"}
      
      {F6439457, size="full"}
      
      {F6439456, size="full"}
      
      {F6439455, size="full"}
      
      {F6439454, size="full"}
      
      {F6439453, size="full"}
      
      {F6439452, size="full"}
      
      {F6439451, size="full"}
      
      Folder View items against the default wallpaper:
      {F6439449, size="full"}
      
      Reviewers: #plasma, hein, #vdg
      
      Reviewed By: #plasma, hein
      
      Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16968
      10278e79
    • Nate Graham's avatar
      Merge branch 'Plasma/5.14' · 1515aa1d
      Nate Graham authored
      1515aa1d
    • Nate Graham's avatar
      Merge branch 'Plasma/5.12' into Plasma/5.14 · 0af2d667
      Nate Graham authored
      0af2d667
    • Nate Graham's avatar
      [Componentchooser KCM] Make default browser app choice work even when combobox is not used · 26fb5ec2
      Nate Graham authored
      Summary:
      BUG: 350663
      FIXED-IN: 5.12.8
      
      When choosing a default browser app using the app list combobox, the choice was only being saved after the combobox was used, because its signal was connected to an inline function that saved the choice, while the radio button that enabled the combobox was not. As a result, if you clicked on that radio button and didn't need to use the combobox because it was already showing your preferred browser, that action was not actually getting saved.
      
      This patch fixes the situation my moving the inline function into a real explicit slot function and connecting the radio button to it as well.
      
      Test Plan:
      - Go to the component chooser KCM's default browser module
      - Reset to defaults, then leave the KCM and open it again
      - Click the {nav in the following application} radio button
      - Do NOT touch the combobox
      - Click {nav Apply}
      - Leave the KCM and come back
      
      With this patch, the radio button's state is preserved and the correct browser is selected in the combobox.
      
      Reviewers: #plasma, cfeck, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17181
      26fb5ec2
  5. 26 Nov, 2018 3 commits
    • Kevin Funk's avatar
      Minor: Fix -Wextra-semi warning · 00eda23e
      Kevin Funk authored
      00eda23e
    • Kevin Funk's avatar
      ASAN: Fix leak in KAStatsFavoritesModel · 7f83492a
      Kevin Funk authored
      Summary:
      Trace:
      Direct leak of 336 byte(s) in 6 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x7fbad15cddaf in KAStatsFavoritesModel::Private::entryForResource(QString const&) const /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:171:24
          #2 0x7fbad15b2d8e in KAStatsFavoritesModel::Private::addResult(QString const&, int, bool) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:280:22
          #3 0x7fbad15b044f in KAStatsFavoritesModel::Private::Private(KAStatsFavoritesModel*, QString) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:233:13
          #4 0x7fbad15a78ea in KAStatsFavoritesModel::initForClient(QString const&) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:485:13
          ...
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17039
      7f83492a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 36bc000d
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      36bc000d
  6. 23 Nov, 2018 2 commits
  7. 22 Nov, 2018 1 commit
  8. 21 Nov, 2018 4 commits
  9. 20 Nov, 2018 1 commit
  10. 19 Nov, 2018 9 commits
    • Krešimir Čohar's avatar
      [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the... · dfce5003
      Krešimir Čohar authored
      [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)
      
      Summary: Leaner separators in Kickoff (less opaque/more see-through, narrower/shorter)
      
      Test Plan:
      This patch would spruce up the much-needed separators in Kickoff that were discussed in D15011 and ultimately added in D15206. It would reduce the opacity of the separators by almost half and make the top separator (between the search field and the rest of the Kickoff menu) as long/wide as a highlighted menu item. This variant was actually put forward in D15011.
      
      >>! In D15011#314514, @ngraham wrote:
      > Perhaps the white background and blinking cursor appear too attention-getting in comparison to the rest of Kickoff, which tries very hard to be flat and gray and avoid separators (e.g. between the different sections and the tab bar at the bottom or the header on top). I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example:
      >
      > {F6212312}
      >
      
      See the difference in the screenshots below:
      
      {F6427577}
      {F6427578}
      
      Reviewers: ngraham, #vdg, romangg
      
      Reviewed By: ngraham, #vdg, romangg
      
      Subscribers: romangg, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16937
      dfce5003
    • Eike Hein's avatar
      Merge branch 'Plasma/5.14' · 7caafc8f
      Eike Hein authored
      7caafc8f
    • Eike Hein's avatar
      Merge branch 'Plasma/5.12' into Plasma/5.14 · 1ca1f240
      Eike Hein authored
      1ca1f240
    • Eike Hein's avatar
      Revert unintended line · 45434737
      Eike Hein authored
      45434737
    • Eike Hein's avatar
      Merge branch 'Plasma/5.14' · ee43381a
      Eike Hein authored
      ee43381a
    • Eike Hein's avatar
      Merge branch 'Plasma/5.12' into Plasma/5.14 · a3039e9f
      Eike Hein authored
      a3039e9f
    • Eike Hein's avatar
      Compress calls to `updateSize` · ab26ebb1
      Eike Hein authored
      Summary:
      Repeater+Flow has no reliable way to transactionize/batch insertion,
      e.g. `Flow.positionCompleted` is useless in a function that can change
      the Flow's size, and transition events like populated and similar
      aren't available. Refactoring this to be a ListView isn't appealing
      because it would mean the code loses the property of being reused for
      both the bar and the popup, and therefore is well-tested already.
      
      This brings down the number of `updateSize` calls when opening the
      dialog for a group of five from five to one.
      
      BUG:400364
      
      Reviewers: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17006
      ab26ebb1
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.14' · 27a3ff42
      Kai Uwe Broulik authored
      27a3ff42
    • Kai Uwe Broulik's avatar
      Remove debug · f8f8b276
      Kai Uwe Broulik authored
      f8f8b276
  11. 18 Nov, 2018 2 commits