GitLab

Summary: BUG: 401932

Test Plan: Opened each

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17458

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Test Plan:
{F6461039}
{F6461040}

Reviewers: #vdg, davidedmundson, ngraham

Reviewed By: #vdg, davidedmundson, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17401

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Currently the icon labels can be at non-integer positions.
This results in ugly font rendering.

Test Plan: Before/after: https://phabricator.kde.org/F6456830

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17365

BUG: 401136
FIXED-IN: 5.15.0

Differential Revision: https://phabricator.kde.org/D17347

bump date + releaseinfo
proofread
fix wrong item name in application meu

Differential Revision: https://phabricator.kde.org/D17226

[Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

Summary:
Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.

This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.

BUG: 379432
FIXED-IN: 5.12.8

Test Plan:
Smallest size, before: {F6426124}
Smallest size, after: {F6426126}
Equal padding on either side of the container itself still works: {F6426129}

There is no change for sizes corresponding to the fourth tick on the slider and beyond

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16901

Summary:
port the applet config dialogs and containments to
QtQuickControls2 and Kirigami modernizing it,
using form layouts, Headings and inline messages.
look is almost the same modulo fixing some misalignments and following
the hig more closely

BUG: 401472
FIXED-IN: 5.15.0

Test Plan:
looked at every wallpaper plugin and
loaded the config dialog of many applets

Reviewers: #plasma, #vdg, broulik, ngraham

Reviewed By: #vdg, ngraham

Subscribers: abetts, ngraham, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17211

Summary:
Fixes regression introduced with ab26ebb1: That diff contained
a change unrelated to the original submission, swapping a || out for
&& in response to a review note. This turns out to have broken things.

BUG:401508

Reviewers: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17219

Summary: BUG:400664

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17004

GIT_SILENT

Summary:
Currently the shadow behind Folder View items' labels is very subtle. This leads to poor contrast against wallpapers that are light-colored, visually busy, or both.

This patch attempts to improve the situation by tightening up the shadow so that it looks more like a subtle, tasteful outline.

BUG: 361228
FIXED-IN: 5.12.8

Test Plan:
Folder View items against various wallpapers:
{F6439459, size="full"}

{F6439458, size="full"}

{F6439463, size="full"}

{F6439457, size="full"}

{F6439456, size="full"}

{F6439455, size="full"}

{F6439454, size="full"}

{F6439453, size="full"}

{F6439452, size="full"}

{F6439451, size="full"}

Folder View items against the default wallpaper:
{F6439449, size="full"}

Reviewers: #plasma, hein, #vdg

Reviewed By: #plasma, hein

Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16968

Summary:
BUG: 350663
FIXED-IN: 5.12.8

When choosing a default browser app using the app list combobox, the choice was only being saved after the combobox was used, because its signal was connected to an inline function that saved the choice, while the radio button that enabled the combobox was not. As a result, if you clicked on that radio button and didn't need to use the combobox because it was already showing your preferred browser, that action was not actually getting saved.

This patch fixes the situation my moving the inline function into a real explicit slot function and connecting the radio button to it as well.

Test Plan:
- Go to the component chooser KCM's default browser module
- Reset to defaults, then leave the KCM and open it again
- Click the {nav in the following application} radio button
- Do NOT touch the combobox
- Click {nav Apply}
- Leave the KCM and come back

With this patch, the radio button's state is preserved and the correct browser is selected in the combobox.

Reviewers: #plasma, cfeck, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17181

Summary:
Trace:
Direct leak of 336 byte(s) in 6 object(s) allocated from:
    #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
    #1 0x7fbad15cddaf in KAStatsFavoritesModel::Private::entryForResource(QString const&) const /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:171:24
    #2 0x7fbad15b2d8e in KAStatsFavoritesModel::Private::addResult(QString const&, int, bool) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:280:22
    #3 0x7fbad15b044f in KAStatsFavoritesModel::Private::Private(KAStatsFavoritesModel*, QString) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:233:13
    #4 0x7fbad15a78ea in KAStatsFavoritesModel::initForClient(QString const&) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:485:13
    ...

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17039

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Now arrow key nav works when opening a panel applet via keyboard
shortcut.
Fixes the same problem as D15856

Test Plan:
Open the window list applet with a keyboard shortcut, move
around with the up and down arrows

Reviewers: #plasma, hein, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16053

Without this patch,
build/kcms/colors/CMakeFiles/kcolorschemeeditor.dir/kcolorschemeeditor_autogen/mocs_compilation.cpp.o
and the resulting /usr/bin/kcolorschemeeditor varied from parallelism.

See https://reproducible-builds.org/ for why this matters.

See also https://bugzilla.opensuse.org/show_bug.cgi?id=1109420

Pushed on behalf of bmwiedemann (Bernhard M. Wiedemann)

Differential Revision: https://phabricator.kde.org/D17076

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Copying src/widgets/jobuidelegate.cpp it's "empty trash"

BUG: 401119

Test Plan: Literally none

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17041

Summary:
Or on category headers.

BUG:400720

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17005

Summary:
Fixes regression introduced in 48b32259.

Thanks to ngraham for pointing out the bug.

Reviewers: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17003

[Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

Summary: Leaner separators in Kickoff (less opaque/more see-through, narrower/shorter)

Test Plan:
This patch would spruce up the much-needed separators in Kickoff that were discussed in D15011 and ultimately added in D15206. It would reduce the opacity of the separators by almost half and make the top separator (between the search field and the rest of the Kickoff menu) as long/wide as a highlighted menu item. This variant was actually put forward in D15011.

>>! In D15011#314514, @ngraham wrote:
> Perhaps the white background and blinking cursor appear too attention-getting in comparison to the rest of Kickoff, which tries very hard to be flat and gray and avoid separators (e.g. between the different sections and the tab bar at the bottom or the header on top). I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example:
>
> {F6212312}
>

See the difference in the screenshots below:

{F6427577}
{F6427578}

Reviewers: ngraham, #vdg, romangg

Reviewed By: ngraham, #vdg, romangg

Subscribers: romangg, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16937