Summary:
Use an icon that looks like it might be related to changing the wallpaper for the {nav Configure Desktop} menu item. This slightly improves discoverability for changing the wallpaper.

CCBUG: 391485

Test Plan:
Desktop Toolbox menu:
{F5769965}

Context menu:
{F5769966}

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, hein, broulik, richardbowen, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11253

By accepting the key event we also keep the TextArea from trying to move the cursor itself potentially undoing our selection in the process.

BUG: 392318
FIXED-IN: 5.12.4

Differential Revision: https://phabricator.kde.org/D11708

rename dir doc/kcontrol/kcmlaunch to doc/kcontrol/kcmlaunchfeedback
scripty automatically generates the correct name for the docmessages catalog, the language docs and the install target

change install target to kcontrol/kcmlaunchfeedback in doc/kcontrol/kcmlaunchfeedback/CMakeLists.txt
english docbook is found by khelpcenter

Differential Revision: https://phabricator.kde.org/D11661

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
--FolderView takes into account the
units.iconSizeHints.panel value when is in panel
in order to switch its appearance from
CompactRepresentation to FullRepresentation
and vice versa.

BUG: 379888

Test Plan:
confirm that in order for FolderView to change to
FullRepresention when it is in panel, it respects
the units.iconSizeHints.panel value.

Reviewers: #plasma, hein, mart

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11651

Summary: BUG:392264

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11665

Summary: BUG:392264

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11665

This reverts commit fe3db8ee.

Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.

When re-reverting we need to be sure to test with clean install
prefixes.

Reviewers: #plasma, kde-i18n-doc, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ltoscano, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10838

Summary:
I'm not the author, but it's pretty clear what the intention was.

We expect to get one result back from proxyModel->match
We use results.first(), so we want to check we have at least one entry.
The assert was written backwards

BUG: 387444

Test Plan: Can now remove a group without a crash

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: graesslin, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11567

Scott Harvey authored Mar 21, 2018 and Eike Hein committed Mar 21, 2018

BUG: 392050

Reviewers: #plasma, hein, davidedmundson, ngraham

Reviewed By: #plasma, hein

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11522

Summary:
kded currently fails to handle list values set for X-KDE-OnlyShowOnQtPlatforms
and will read the whole value as one string "xcb;" including the semicolon.

Reviewers: mart, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11126

Summary:
Calling beginRemoveRows() when the model is empty hits an assert in
QAbstractItemModel which requires that the "last" argument is less
than model row count, which is not true when the model is empty.

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11518

Summary: use the new install macro to install bundled packages in the form of an rcc

Test Plan: opened and used a bit every single plasmoid

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11515

remove menubar style options
add info how to use global menu now

Differential Revision: https://phabricator.kde.org/D11455

Summary:
On Defaults the updated values need to be resynced to the QML part.
Otherwise the UI is not updated.

BUG: 392029

Test Plan: Manually tested in Wayland session.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11471

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.

CCBUG: 379432

Test Plan:
Before, normal-sized icons:
{F5755097}

After, normal-sized icons:
{F5755128}

Before: small icons:
{F5755102}

After, small icons:
{F5755127}

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11358

Ensures changes take effect immediately

Differential Revision: https://phabricator.kde.org/D11327

Radek Bucek authored Mar 15, 2018 and Eike Hein committed Mar 15, 2018

BUG: 386546

plasma-desktop - bad textarea width in rename file

steps for replicate:

create file (on plasma-destkop) with filename 't1'
try rename file to: 't1 test test'

Reviewers: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10837

Standard Shortcuts (e.g. Ctrl+C for Copy) are the least likely shortcuts to be changed.

Differential Revision: https://phabricator.kde.org/D11103

Summary:
ListView.contentItem does crazy things when the view is set
to 0 height, causing ScrollArea to show a scrollbar. This
avoids it.

Also cleans up a warning about anchoring the highlight on
the side.

BUG:391644

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11254

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The width and height are also scaled, we need to get the native width
and height before we do the repositioning.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"