GitLab

Summary:
BUG: 414417
* While saving a new global theme, don't set splash screen if none is provided, leave the current one.
* KSplash kcfg set default to breeze instead of the current lnf theme which may not contain a splash screen.

Test Plan:
* Open LookAndFeel KCM, apply Breeze Dark, then open Splash screen KCM, Breeze should be highlighted.
* Open splash screen KCM, select none, click on defaults, Breeze should be selected.

Reviewers: #plasma, ervin, bport, meven, ngraham

Reviewed By: ervin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28656

Summary:
BUG: 419552
* Some Global Theme may refer to breeze widget style with a lower case b, apply the proper name `Breeze`

BUG: 418698
* Some Global Theme use widget style that may not be installed, then don't apply it.

Test Plan:
* Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply it. Open Application Style KCM, if kvantum is not installed, Breeze is highlighted.
* Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. Open Application Style KCM, Breeze is highlighted.

Reviewers: #plasma, ervin, bport, meven, ngraham

Reviewed By: ervin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28662

Summary: BUG: 397595

Test Plan:
KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid.
In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value.

With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted.

Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27483

(cherry picked from commit 6d3d3ffa)

Summary:
With this change the lookandfeel KCM can be built without X11 cursor development headers.
In the case the KCM is built without XCursor support, it will not be able to reload the cursor dynamically at runtime but it will still be able to configure cursor themes.

This is an alternative to: D26344 (https://phabricator.kde.org/D26344)

Test Plan: plasma-desktop builds using kdesrc-build with and without X11 cursor development headers present.

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26367

Reviewers: #plasma, ervin, mart, bport, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25274

Summary:
This removes the need for the custom hack for spawning a dialog,
and is intended to function as a sample for how to implement this
in other KCMs.

Also use the big, pretty Preview mode (because super-visual content)

This could be done wholesale for the entire bunch of KCMs, but i post
this on its own in an attempt to gain feedback on a self contained
example of how to do this porting step.

Without this patch:
{F7668236}

With this patch:
{F7668234}

Depends on D25041

Reviewers: #plasma, #knewstuff, #vdg, broulik, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24942

Summary: little work to remove warning before moving LnF KCM to KConfigXT

Test Plan: Should compile and remove Plasma::Package deprecated warnings

Reviewers: #plasma, ervin, mart, bport

Differential Revision: https://phabricator.kde.org/D24820

KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

Summary: Clean up before moving LnF KCM to KConfigXT

Test Plan: Compile

Reviewers: #plasma, ervin, mart, bport

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24819

Summary:
The workaround is not necessary anymore.
See https://bugreports.qt.io/browse/QTBUG-40765
See also D22012

Test Plan: Manually tested

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23175

Summary:
This implements one of the changes decided upon in T11314. The rationale is as follows:

The old text ("Look and Feel") is a generic term and could be referring to any of the
other appearance settings. The new text "Global Theme" is more descriptive and accurate
and makes this KCM's relationship to everything else clear, especially once it's the only
KCM that uses the word "Theme" (see D22880).

Test Plan: {F7142701}

Reviewers: #vdg, #plasma, GB_2, mart

Reviewed By: #vdg, #plasma, GB_2, mart

Subscribers: mart, GB_2, plasma-devel

Tags: #plasma

Maniphest Tasks: T11314

Differential Revision: https://phabricator.kde.org/D22879

in order for the lnf apply to fully work more than once m_package needs
to reflect the current theme when a new one is applied

Filip Fila authored Feb 13, 2019 and Krešimir Čohar committed Feb 13, 2019

Summary:
With the purpose of making KCMs more consistent and following the HIG, this patch does the following:

- Converts all .desktop file "Comment" values into action(verb)-style labels
- Drops the use of articles in "Comment" values
- Changes the KAboutData i18n strings so that they match the respective KCM's name

Reviewers: GB_2, #vdg, ngraham, #plasma

Reviewed By: GB_2, #vdg, ngraham

Subscribers: davidedmundson, broulik, plasma-devel

Tags: #plasma

Maniphest Tasks: T10273

Differential Revision: https://phabricator.kde.org/D18903

BUG: 400404
FIXED-IN: 5.15.1

Differential Revision: https://phabricator.kde.org/D18815

We copy the .colors file's contents into kdeglobals and I have seen many of them containing bogus

[General]
ColorScheme=Some Other Scheme
which makes no sense. Ensure the ColorScheme that ends up in kdeglobals is the scheme defined by the look and feel package.

BUG: 403774
FIXED-IN: 5.15.0

Differential Revision: https://phabricator.kde.org/D18754

Summary:
The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.
{F6546516}

Test Plan: Open the LnF KCM

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma

Tags: #plasma

Maniphest Tasks: T10273

Differential Revision: https://phabricator.kde.org/D18206

Makes it consistent with the other KCMs.

Differential Revision: https://phabricator.kde.org/D13103

Summary:
use the new design for the look and feel kcm, together with
a massive code simplification

Test Plan: pply does work, as preview of themes

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12090

Summary:
support the new standalone splashscreens of D11918
also add a GHNS button for the new splashscreen store category

FEATURE: 358839

Test Plan:
splashscreens are correctly listed, installed and removed
both ones in lnf packages and standalone are listed.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11919

Summary:
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Moving the K_PLUGIN_FACTORY_WITH_JSON into a separate file only added
to the sources of kcm_lookandfeel, instead of hiding with an ifndef for
the build of the lookandfeeltool target as tried before, should avoid
any potential confusion of automoc as reported from some builds
(on KDE neon?).

Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10607

This reverts commit 502e8dc1.

It causes error undefined reference to 'vtable for
KCMLookandFeelFactory' while linking, as reported by psifidotos on IRC
channel.

This reverts the D10485

Summary:
Using one argument with "KSharedConfig::openConfig(filename)" actually
results in using the default value for the second argument, "FullConfig".
Which results also in "Blend kdeglobals into the config object."
As a result the color scheme file opened in KCMLookandFeel::setColors(...)
this way has the complete global config groups and settings (with the data
as stored on the disc, not in any runtime working copies) mapped into the
profile (incl. e.g. the group "[General]" with the entry "ColorScheme").
So when then all the groups are copied over from the scheme config, actually
also all the stored global config groups and settings are copied over,
overwriting the not yet synced [General]/ColorScheme entry, which was just
set a few lines before, again with the old value from the storage.

Possibly the old code which was doing the sync right after setting the new
scheme value had been there exactly to protect against that
(cmp. change in cf49d415).

Reviewers: broulik, davidedmundson, mart

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10259

Summary:
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10485

I have configured my system to use an 48 px mouse cursor. When applying a new look and feel theme, it might change the cursor
at runtime but load it with default size. Since the size is never actually changed, on next startup the previous size is restored,
but it should apply it correctly already.

Differential Revision: https://phabricator.kde.org/D10055

BUG: 370162
FIXED-IN: 5.12.0

Differential Revision: https://phabricator.kde.org/D10056

Summary:
using the kcm c++ itself to do the switch, have a tool
that can be used to switch lnf package from the command line

Test Plan: running the tool has the same effect of chosing a lnf trough the kcm

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9411

Summary:
meant to support layouts that want external apps such as lattedock
or conky, it adds services (in the defaults file they're saved as
the filename of the desktop file) in autostart and starts immediately
the app as well.
before applying a lnf, it removes from autostart anything the old
package had and attempts to stop the apps

Test Plan:
tried to start/stop lattedock with the mechanism
some fallback may be needed for non kde apps

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, mvourlakos, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9288

REVIEW: 129875
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

Summary:
why this loop trough all the scheme files?
the scheme theme name is an heuristic, there is no plugin metadata whatsoever.
is based on the file name stripped from weird characters or the
eventual id- prefix store.kde.org puts, so we can just find a
theme that ends as the specified name

Test Plan:
now themes downloaded from store.kde.org are correctly applied
such as "Kshell" use case

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4066

Summary:
support both button order and decoration theme
of kwin when applying for a lnf theme. The deco
theme is composed by library and theme entries.
c++ themes will only use library, aurorae themes will use
theme as well.

BUG:370511

Test Plan: created some lnf packages that customize this and applied

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: Lucas, graesslin, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3832

Summary:
    remove the timer that selects the index at startup
    that caused flickering and things moving around since
    index 0 got selected, then moved to the correct one only after a while.

    unfortunately there is not a place (a signal) that says
    "the view has been correctly instanced from the model" that
    would be where selecting the current index at startup would be the safest.
    a place that seems working correctly is on listview onCountChanged

    this has to introduce KCMLookandFeel::selectedPluginIndex
    that isn't very pretty, but the flickering seems to be gone and
    the kcm loads from the correct place of the view from the first
    frame is displayed

Test Plan: he flickering seems to be gone and the kcm loads from the correct place of the view from the first frame is displayed. Once this is in the final form, some other config dialogs need the same treatment: plasma theme and wallpapers

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3528

Summary:
preview button for themes, launches a fullscreen preview for the theme
the preview image is shown as big as possible, either 1:1 or
scaled down to screen size.

clicking anywhere (or in the top right close button) dismissed the
fullscreen dialog

the thumbnail uses a plasma toolbutton, but in that particular point is fine
to use a plasma control, because it's on top of an image, it's
a custom graphics zone, where on the other hand a system style
toolbutton wouldn't work well.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma, #vdg

Differential Revision: https://phabricator.kde.org/D2550

Summary:
the shell has 2 methods to switch lnf layout:
one that throws away the config contents, one that
keeps them

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: colomar, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2448

Summary:
Fixes updating palette in running applications.

BUG: 359924

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: graesslin, plasma-devel

Projects: #plasma

Differential Revision: https://phabricator.kde.org/D1045