1. 20 Aug, 2015 4 commits
  2. 19 Aug, 2015 3 commits
  3. 18 Aug, 2015 1 commit
  4. 17 Aug, 2015 1 commit
  5. 16 Aug, 2015 3 commits
  6. 15 Aug, 2015 1 commit
  7. 14 Aug, 2015 1 commit
  8. 13 Aug, 2015 2 commits
  9. 12 Aug, 2015 2 commits
  10. 11 Aug, 2015 1 commit
  11. 10 Aug, 2015 2 commits
  12. 08 Aug, 2015 4 commits
    • Ivan Čukić's avatar
      5cf4bfaa
    • Maxim Mikityanskiy's avatar
      Fix segfaults in kcm_keyboard · a20e1e5c
      Maxim Mikityanskiy authored
      There are two scenarios that lead to segfault in kcm_keyboard.
      
      1. Run kcmshell5 keyboard; switch to the second tab; in layouts table
      double-click on item in third column so that combo box appears; click on
      empty space in layouts table; [Preview] button does not get deactivated;
      click on that button and see kcm_keyboard crashing.
      2. Run kcmshell5 keyboard; switch to the second tab; modify something so
      that [Reset] button becomes active; select any row in layouts table;
      click on [Reset]; row becomes deselected, but [Preview] button is still
      active; click on that button and see kcm_keyboard crashing.
      
      [Preview] button should become inactive when no rows are selected, but
      in these two scenarios it doesn't.
      KCMKeyboardWidget::layoutSelectionChanged slot does not get called in
      these two cases. What happens in described cases:
      
      1. layoutsTableModel emits dataChanged signal.
      KCMKeyboardWidget::uiChanged slot gets called.
      LayoutsTableModel::refresh is called, then in
      QAbstractItemModel::endResetModel modelReset signal is emitted,
      QAbstractItemView::reset slot gets called, and it calls
      QItemSelectionModel::reset. QItemSelectionModel::reset disables signals
      and calls QItemSelectionModel::clear that calls
      QItemSelectionModel::clearSelection, but signals are disabled, so
      itemSelectionChanged is not emitted, and
      KCMKeyboardWidget::layoutSelectionChanged is not called.
      2. KCMKeyboard::load calls KCMKeyboardWidget::updateUI that calls
      LayoutsTableModel::refresh. All following calls are in the same order as
      in case 1.
      
      I propose to call KCMKeyboardWidget::layoutSelectionChanged manually
      after problematic refreshes to update buttons state. It's not the best
      fix, there still may be places where manual call of
      layoutSelectionChanged is needed, but at least it fixes two segfaults.
      
      REVIEW: 124659
      BUG: 124659
      a20e1e5c
    • David Edmundson's avatar
      Remove unused import · d47538c4
      David Edmundson authored
      d47538c4
    • Ivan Čukić's avatar
      Cosmetic surgery of the activity switcher · 41573e6e
      Ivan Čukić authored
      - Refactoring the dialog handling
      - Dialogs are now truly inline
      - Fixed a few layout and positioning bugs
      41573e6e
  13. 07 Aug, 2015 2 commits
  14. 06 Aug, 2015 2 commits
  15. 03 Aug, 2015 1 commit
  16. 02 Aug, 2015 2 commits
  17. 31 Jul, 2015 4 commits
  18. 30 Jul, 2015 4 commits