GitLab

CHANGELOG: Automatic mounting of external storage is now possible again

REVIEW: 124730
BUG: 351003
FIXED-IN: 5.5.0

BUG: 350135
REVIEW: 124837

GIT_SILENT

When assigning a shortcut to the application dashboard, pressing it would still just
open the popup revealing it's actually Kicker.

BUG: 351290
FIXED-IN: 5.4.0

BUG: 351412

This was broken in a way that meant i18n wasn't loaded and the English
version had random HTML entities.

BUG: 341527
REVIEW: 124737

Otherwise the left mouse action isn't triggered

BUG: 351277
FIXED-IN: 5.4.0

Otherwise the left mouse action isn't triggered

BUG: 351277
FIXED-IN: 5.4.0

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

REVIEW:124702

REVIEW:124702

REVIEW:124625

You couldn't wheel to switch desktops hovering one of the gaps

BUG: 351173
FIXED-IN: 5.4.0

There are two scenarios that lead to segfault in kcm_keyboard.

1. Run kcmshell5 keyboard; switch to the second tab; in layouts table
double-click on item in third column so that combo box appears; click on
empty space in layouts table; [Preview] button does not get deactivated;
click on that button and see kcm_keyboard crashing.
2. Run kcmshell5 keyboard; switch to the second tab; modify something so
that [Reset] button becomes active; select any row in layouts table;
click on [Reset]; row becomes deselected, but [Preview] button is still
active; click on that button and see kcm_keyboard crashing.

[Preview] button should become inactive when no rows are selected, but
in these two scenarios it doesn't.
KCMKeyboardWidget::layoutSelectionChanged slot does not get called in
these two cases. What happens in described cases:

1. layoutsTableModel emits dataChanged signal.
KCMKeyboardWidget::uiChanged slot gets called.
LayoutsTableModel::refresh is called, then in
QAbstractItemModel::endResetModel modelReset signal is emitted,
QAbstractItemView::reset slot gets called, and it calls
QItemSelectionModel::reset. QItemSelectionModel::reset disables signals
and calls QItemSelectionModel::clear that calls
QItemSelectionModel::clearSelection, but signals are disabled, so
itemSelectionChanged is not emitted, and
KCMKeyboardWidget::layoutSelectionChanged is not called.
2. KCMKeyboard::load calls KCMKeyboardWidget::updateUI that calls
LayoutsTableModel::refresh. All following calls are in the same order as
in case 1.

I propose to call KCMKeyboardWidget::layoutSelectionChanged manually
after problematic refreshes to update buttons state. It's not the best
fix, there still may be places where manual call of
layoutSelectionChanged is needed, but at least it fixes two segfaults.

REVIEW: 124659
BUG: 124659

- Refactoring the dialog handling
- Dialogs are now truly inline
- Fixed a few layout and positioning bugs

Scripts are run at logout not shutdown

BUG: 351036

Update version number for 5.4.90

Update version number for 5.3.95

For some reason we have two IconDialog's exported to QML.

One in KDeclarative, one in Plasma-Frameworks/platformcomponents.

The one in plasmacomponents performs an exec() in the main thread from
QML which is a very bad idea. the one in kdeclarative is good.

BUG: 350864
REVIEW: 124580

REVIEW:124296

user-manager does everything useraccount does so use that instead

post 5.4 a rewrite of kcm_useraccount needs to be evaluated if it's better
http://comments.gmane.org/gmane.comp.kde.devel.plasma/42358

FEATURE

It only adds systemsettings once but still it shows up twice /o\