1. 02 Nov, 2019 1 commit
  2. 31 Oct, 2019 13 commits
    • Björn Feber's avatar
      [Task Manager] Toggle mute when the audio indicator is clicked · da268696
      Björn Feber authored
      The task manager shows an indicator on tasks playing audio (when
      enabled in the settings). This patch adds the ability to mute/unmute
      an application playing audio by clicking on the audio indicator in
      the task manager.
      Test Plan:
      * Check "Mark applications that play audio" in the Task Manager Settings
      * Open an application that plays audio
      * Click on the audio indicator and it should toggle the mute state
      Reviewers: #plasma, #vdg, ngraham, filipf, hein, faridb
      Reviewed By: #plasma, #vdg, ngraham, hein
      Subscribers: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D19822
    • Kevin Ottens's avatar
      Fix reset to defaults in the fonts KCM · 7b0149c7
      Kevin Ottens authored
      Turns out one of the properties was utterly broken emitting the wrong
      signal, and the defaults() method was missing a piece of state to reset.
      Since it was making my eyes bleed I also removed the "const int &"
      parameters in the process. :-)
      Reviewers: #plasma, bport, davidedmundson, mart
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25094
    • Nate Graham's avatar
      [containments/desktop] Delete the "Tweaks" page and its options · 69d649e5
      Nate Graham authored
      With the new global edit mode, both of the options on the Tweaks page become unnecessary:
      - The option to hide the toolbox becomes dangerous because it breaks global edit mode
      - The option to toggle press-and-hold is unnecessary with the far superior global edit mode
      Test Plan:
      - Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list: {F7687032}
      - Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
      - You can no longer turn off the toolbox and break edit mode
      - You can no longer toggle the press-and-hold checkbox to show widget handles by hovering over widgets for a few seconds
      Reviewers: mart, GB_2, #plasma, hein
      Reviewed By: mart, #plasma
      Subscribers: fabianr, broulik, plasma-devel
      Tags: #plasma
      Maniphest Tasks: T10402
      Differential Revision: https://phabricator.kde.org/D25055
    • Mikhail Zolotukhin's avatar
      Notify about change after cursor config is saved · cf7254a7
      Mikhail Zolotukhin authored and Nate Graham's avatar Nate Graham committed
      Before that patch the cursor change signal was only transmitted after
      a configuration was applied on a fly. Because the cursor change is
      not applied on a fly on Wayland session yet, the signal is not emitted and
      therefore users of that signal are not notified about cursor change.
      Now the signal is emitted after the configuration save, so its users are
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24701
    • Aleix Pol Gonzalez's avatar
      kimpanel: don't crash when ibus is already loaded · 299f298d
      Aleix Pol Gonzalez authored
      No need to replace the current engine if we already have an acceptable one set.
      Otherwise it confuses Qt and it asserts in Qt.
       7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion@entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file@entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
          line=line@entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
       8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
       9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147
      Test Plan:
      Now I can start the plasmoid without it crashing.
      I'm guessing users so far were running against a release build of Qt without asserts.
      Starting ibus with the session now works as well, in contrast to having to start it explicitly
      Reviewers: hein
      Reviewed By: hein
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25045
    • David Edmundson's avatar
      [kcms/krdb] Fix krdb executable · 3a6dc8c0
      David Edmundson authored
      krdb is mostly a library used by some KCMs.
      It also exists as an executable script that works by invoking kcminit
      style which in turn runs the krdb code.
      This broke after a port that involved a rename.
      Test Plan:
      krdb on a distro that doesn't have old files
      It ran instead of giving a warning
      Reviewers: #plasma, apol
      Reviewed By: apol
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25081
    • Benjamin Port's avatar
      fix kcm fonts "typo" on connect · 08a8914d
      Benjamin Port authored
      Summary: connect was not done correctly
      Reviewers: #plasma, mart, ervin, broulik
      Reviewed By: #plasma, ervin, broulik
      Subscribers: broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24848
    • Cyril Rossi's avatar
      KCM KSplash port to ManagedConfigModule · 33222600
      Cyril Rossi authored
      Reviewers: #plasma, ervin, mart, bport
      Subscribers: davidedmundson, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24925
    • Cyril Rossi's avatar
      KCM Style port to KConfigXT · fbed4b3e
      Cyril Rossi authored
      Reviewers: ervin, mart, bport, #plasma
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24917
    • Vlad Zahorodnii's avatar
      Merge branch 'Plasma/5.17' · 45439589
      Vlad Zahorodnii authored
    • Vlad Zahorodnii's avatar
      [Night Color KCM] Reset seconds and milliseconds in provided timings · 59e30039
      Vlad Zahorodnii authored
      When a user tries to set operation mode to "Times", the Apply button
      remains enabled after it's been clicked. The reason for that is timings
      provided by the kcm include seconds and milliseconds, while timings
      sent by KWin don't.
      Because seconds and milliseconds are different, CompositorAdapter::
      checkStaged() will return false even though hours and minutes haven't
      been modified by the user.
      In order to address this problem, my patch adjusts the TimeField
      component so it provides Date objects with seconds and milliseconds set
      to 0. There is another way to fix this issue though. We could check in
      CompositorAdaptor::checkStaged() method whether only hours and
      minutes have been modified.
      Test Plan:
      - Set operation mode to "Times"
      - Click the Apply button
      - Check that the Apply button is disabled
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25047
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · f0502407
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · baad1dff
      Script Kiddy authored
  3. 30 Oct, 2019 4 commits
    • Björn Feber's avatar
      Rename "Close Edit Mode" tooltip to "Finish Customizing Layout" · a74c3657
      Björn Feber authored
      Summary: We don't call it the "edit mode" anywhere else in the UI. It now also matches the menu entry.
      Test Plan: Hover over the desktop toolbox close button.
      Reviewers: #plasma, #vdg, ngraham, mart
      Reviewed By: #plasma, #vdg, ngraham, mart
      Subscribers: mart, ngraham, #vdg, plasma-devel, #plasma
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24855
    • Kevin Ottens's avatar
      Force reevaluating state on pending deletion changes · 35c84cb5
      Kevin Ottens authored
      This was missing and thus the apply button wouldn't get enabled in case
      of a pending deletion. This is due to this mechanism being outside of
      the KConfigXT realm.
      Reviewers: #plasma, bport, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25076
    • Kevin Ottens's avatar
      Adjust QtQuickSettings KCM to use KConfigXT in full · 61cd3d4b
      Kevin Ottens authored
      This removes quite a lot of uneeded code and fixes the automatic default
      handling from KConfigXT point of view (this was the wrong integration
      scheme with combo boxes).
      It also gives me a nice testing ground for a widget based KCM usable
      with kcmshell. :-)
      Reviewers: #plasma, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25068
    • Dan Leinir Turthra Jensen's avatar
      Require and use the new NewStuffQuick Button component · c21a8bd8
      Dan Leinir Turthra Jensen authored
      This removes the need for the custom hack for spawning a dialog,
      and is intended to function as a sample for how to implement this
      in other KCMs.
      Also use the big, pretty Preview mode (because super-visual content)
      This could be done wholesale for the entire bunch of KCMs, but i post
      this on its own in an attempt to gain feedback on a self contained
      example of how to do this porting step.
      Without this patch:
      With this patch:
      Depends on D25041
      Reviewers: #plasma, #knewstuff, #vdg, broulik, ngraham
      Reviewed By: #vdg, ngraham
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24942
  4. 29 Oct, 2019 5 commits
  5. 28 Oct, 2019 2 commits
  6. 27 Oct, 2019 1 commit
  7. 25 Oct, 2019 1 commit
  8. 24 Oct, 2019 4 commits
  9. 23 Oct, 2019 4 commits
  10. 22 Oct, 2019 5 commits