GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The task manager shows an indicator on tasks playing audio (when
enabled in the settings). This patch adds the ability to mute/unmute
an application playing audio by clicking on the audio indicator in
the task manager.

Test Plan:
* Check "Mark applications that play audio" in the Task Manager Settings
* Open an application that plays audio
* Click on the audio indicator and it should toggle the mute state
{F7324364}

Reviewers: #plasma, #vdg, ngraham, filipf, hein, faridb

Reviewed By: #plasma, #vdg, ngraham, hein

Subscribers: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19822

Summary:
Turns out one of the properties was utterly broken emitting the wrong
signal, and the defaults() method was missing a piece of state to reset.

Since it was making my eyes bleed I also removed the "const int &"
parameters in the process. :-)

Reviewers: #plasma, bport, davidedmundson, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25094

Summary:
With the new global edit mode, both of the options on the Tweaks page become unnecessary:
- The option to hide the toolbox becomes dangerous because it breaks global edit mode
- The option to toggle press-and-hold is unnecessary with the far superior global edit mode

Test Plan:
- Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list: {F7687032}
- Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
- You can no longer turn off the toolbox and break edit mode
- You can no longer toggle the press-and-hold checkbox to show widget handles by hovering over widgets for a few seconds

Reviewers: mart, GB_2, #plasma, hein

Reviewed By: mart, #plasma

Subscribers: fabianr, broulik, plasma-devel

Tags: #plasma

Maniphest Tasks: T10402

Differential Revision: https://phabricator.kde.org/D25055

Mikhail Zolotukhin authored Oct 31, 2019 and Nate Graham committed Oct 31, 2019

Summary:
Before that patch the cursor change signal was only transmitted after
a configuration was applied on a fly. Because the cursor change is
not applied on a fly on Wayland session yet, the signal is not emitted and
therefore users of that signal are not notified about cursor change.

Now the signal is emitted after the configuration save, so its users are
notified.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24701

Summary:
No need to replace the current engine if we already have an acceptable one set.

Otherwise it confuses Qt and it asserts in Qt.

```
 7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion@entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file@entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
    line=line@entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
 8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
 9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147
```

Test Plan:
Now I can start the plasmoid without it crashing.
I'm guessing users so far were running against a release build of Qt without asserts.
Starting ibus with the session now works as well, in contrast to having to start it explicitly

Reviewers: hein

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25045

Summary:
krdb is mostly a library used by some KCMs.

It also exists as an executable script that works by invoking kcminit
style which in turn runs the krdb code.

This broke after a port that involved a rename.

Test Plan:
krdb on a distro that doesn't have old files
It ran instead of giving a warning

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25081

Summary: connect was not done correctly

Reviewers: #plasma, mart, ervin, broulik

Reviewed By: #plasma, ervin, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24848

Reviewers: #plasma, ervin, mart, bport

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24925

Reviewers: ervin, mart, bport, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24917

Summary:
When a user tries to set operation mode to "Times", the Apply button
remains enabled after it's been clicked. The reason for that is timings
provided by the kcm include seconds and milliseconds, while timings
sent by KWin don't.

Because seconds and milliseconds are different, CompositorAdapter::
checkStaged() will return false even though hours and minutes haven't
been modified by the user.

In order to address this problem, my patch adjusts the TimeField
component so it provides Date objects with seconds and milliseconds set
to 0. There is another way to fix this issue though. We could check in
CompositorAdaptor::checkStaged() method whether only hours and
minutes have been modified.

Test Plan:
- Set operation mode to "Times"
- Click the Apply button
- Check that the Apply button is disabled

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25047

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: We don't call it the "edit mode" anywhere else in the UI. It now also matches the menu entry.

Test Plan: Hover over the desktop toolbox close button.

Reviewers: #plasma, #vdg, ngraham, mart

Reviewed By: #plasma, #vdg, ngraham, mart

Subscribers: mart, ngraham, #vdg, plasma-devel, #plasma

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24855

Summary:
This was missing and thus the apply button wouldn't get enabled in case
of a pending deletion. This is due to this mechanism being outside of
the KConfigXT realm.

Reviewers: #plasma, bport, mart, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25076

Summary:
This removes quite a lot of uneeded code and fixes the automatic default
handling from KConfigXT point of view (this was the wrong integration
scheme with combo boxes).

It also gives me a nice testing ground for a widget based KCM usable
with kcmshell. :-)

Reviewers: #plasma, mart, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25068

Summary:
This removes the need for the custom hack for spawning a dialog,
and is intended to function as a sample for how to implement this
in other KCMs.

Also use the big, pretty Preview mode (because super-visual content)

This could be done wholesale for the entire bunch of KCMs, but i post
this on its own in an attempt to gain feedback on a self contained
example of how to do this porting step.

Without this patch:
{F7668236}

With this patch:
{F7668234}

Depends on D25041

Reviewers: #plasma, #knewstuff, #vdg, broulik, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24942

GIT_SILENT

Summary:
In D24839 we hide "Lock Widgets" from the UI, so do the same thing here.

BUG: 412433

Test Plan: Open the panel edit mode.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: #vdg, plasma-devel, #plasma

Tags: #plasma

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D24162

Gabriel Craciunescu authored Oct 28, 2019 and Nate Graham committed Oct 28, 2019

Summary:
The kcm UI has right now a step size of 24 with a max size of 1000 and a minimum of 1.

Max size need to divide to step size and the lowest possible value should be the step size
because  0 means disabled.

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25004

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Done by clazy

Summary:
All the other platforms that have implemented this feature offer a little inline
explanation of what it is and what it does, but we do not. I think it makes sense to add
our own, since it's not a totally intuitive thing.

Test Plan: {F7659929}

Reviewers: #vdg, #plasma, ndavis, zzag

Reviewed By: #vdg, #plasma, ndavis, zzag

Subscribers: ahiemstra, davidedmundson, ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24906

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Settings for icons effect where removed in plasma 5.16, cleanup config file and code

Test Plan: Added manually entry to my config file and after script was run the entry was not there anymore

Reviewers: #plasma, mart, broulik, ervin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24845

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Mirai Komachi authored Oct 22, 2019 and Nate Graham committed Oct 22, 2019

Summary:
LIBINPUT_PROP_ACCEL_PROFILE_ENABLED contains two values,
valueWriterPart<bool> function didn't handle it correctly.

BUG: 398713
FIXED-IN: 5.17.1

Reviewers: #plasma, romangg, ngraham

Reviewed By: #plasma, romangg, ngraham

Subscribers: anthonyfieroni, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24711

Summary: This depends on https://phabricator.kde.org/D24821

Reviewers: mart, bport, crossi, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24822

Summary: little work to remove warning before moving LnF KCM to KConfigXT

Test Plan: Should compile and remove Plasma::Package deprecated warnings

Reviewers: #plasma, ervin, mart, bport

Differential Revision: https://phabricator.kde.org/D24820