GitLab

Tobias Fella authored Aug 18, 2020 and Nate Graham committed May 06, 2021

button

BUG: 425436
(cherry picked from commit 6925dd2f)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

It defaults to Qt::MatchStartsWith and thus returns the wrong result.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

David Edmundson authored Sep 25, 2020 and Nate Graham committed Jan 19, 2021

We're not binding to the action so we don't want setGlobalShortcut. We
also need to not autoload in order to actually save anything.

BUG: 374575


(cherry picked from commit c5413826)

(cherry picked from commit 33fd3058)

(cherry picked from commit 395aba0f)

Folder view has some logic to switch between its compact and full
representations for vertical panels, but it is faulty, and causes the
switch to happen at approximately 50px width. At this width, the display
is completely unusable as the text is elided away into nothingness.

This commit remedies the situation by imposing a more sane minimum width
based on gridUnit. With the default 10pt font, the minimum thickness is
now 144px, which leaves enough room for the labels to be at least
partially visible. At lower panel widths, the applet displays its compact
representation.

BUG: 406806
FIXED-IN: 5.18.7

Xuetian Weng authored Dec 17, 2020 and Nate Graham committed Dec 22, 2020

Right now due to the fact that it is a shared config, we may load the
old value from memory.

BUG: 418175
FIXED-IN: 5.21
(cherry picked from commit 27a64b96)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Due to KConfig dropping QFont styleName property (for "Regular"-like font
styles, see [1] for more details), the font selection dialog invoked by the
KCM could end up selecting the wrong style; this change sets the appropriate
"Regular" style on the QFont object before invoking the font selection dialog
to fix/workaround the issue.

Note that in Plasma master branch the issue is handled differently, since
we switched from QFontDialog to KFontChooserDialog (the latter has that
logic built-in).

[1] https://phabricator.kde.org/D27735

CCBUG: 420287

Locations are folders. Set the appropriate hint in order to get folder dialogs.

BUG: 424438
FIXED-IN: 5.18.6
(cherry picked from commit 40499005)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fixes duplicate breeze entry after installing a cursor theme from a local file.


(cherry picked from commit caa0ecbb)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Matej Mrenica authored May 06, 2020 and Nate Graham committed May 06, 2020

Summary:
When using fractional scaling, bottom icons are blurred. This patch fixes the issue.

BUG: 418165

Test Plan:
No side effects.

Before:
{F8289358}
After:
{F8289369}

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29481

GIT_SILENT

So KRunner can catch that in a KConfigWatcher

Differential Revision: https://phabricator.kde.org/D29410

Summary:
Changing the icon size should emits `KIconloader::iconLoaderSettingsChanged` as well

BUG: 420577
FIXED-IN: 5.18.5

Reviewers: #plasma, bport, broulik

Reviewed By: #plasma, bport, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29285

The lambda returns a QStringBuilder which contains dangling references, see also QTBUG-47066

BUG: 420452
FIXED-IN: 5.18.5

Differential Revision: https://phabricator.kde.org/D29224

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
BUG: 414417
* While saving a new global theme, don't set splash screen if none is provided, leave the current one.
* KSplash kcfg set default to breeze instead of the current lnf theme which may not contain a splash screen.

Test Plan:
* Open LookAndFeel KCM, apply Breeze Dark, then open Splash screen KCM, Breeze should be highlighted.
* Open splash screen KCM, select none, click on defaults, Breeze should be selected.

Reviewers: #plasma, ervin, bport, meven, ngraham

Reviewed By: ervin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28656

Summary:
BUG: 419552
* Some Global Theme may refer to breeze widget style with a lower case b, apply the proper name `Breeze`

BUG: 418698
* Some Global Theme use widget style that may not be installed, then don't apply it.

Test Plan:
* Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply it. Open Application Style KCM, if kvantum is not installed, Breeze is highlighted.
* Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. Open Application Style KCM, Breeze is highlighted.

Reviewers: #plasma, ervin, bport, meven, ngraham

Reviewed By: ervin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28662

Will submit a patch to calculate the width automtically so we don't need
to hardcode this and manually update it again in the future.

BUG: 420385
FIXED-IN: 5.18.5

Tranter Madi authored Apr 20, 2020 and Nate Graham committed Apr 20, 2020

Summary:
When the root is in the "Search" state, we can safely disable it.

BUG: 401861

Reviewers: #plasma, hein, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28985

This reverts commit ba66d2ea.

Summary:
BUG: 377653
FIXED-IN: 5.18.5

Test Plan:
Before: {F7884930}
After: {F7884929}

Reviewers: #plasma

Subscribers: cfeck, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26695