1. 06 May, 2021 1 commit
  2. 19 Feb, 2020 1 commit
    • George Vogiatzis's avatar
      [Folder view]Make shadow scale aware · 4056e24b
      George Vogiatzis authored and Nate Graham's avatar Nate Graham committed
      Summary: Added devicePixelRatio to shadow's radius.
      
      Test Plan:
      Check the shadow of items on the desktop.
      Compare scale 100% vs big display scale (e.g. 300%).
      Before: Shadow is invisible.
      After: Visible shadow at every display scale.
      
      Before vs After
      Scale 300% and 100%
      {F8097331,size=full}
      
      Reviewers: #plasma, #vdg, apol, ngraham, davidedmundson
      
      Reviewed By: #plasma, #vdg, apol, ngraham, davidedmundson
      
      Subscribers: broulik, davidedmundson, apol, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27316
      4056e24b
  3. 21 Nov, 2019 1 commit
    • Nate Graham's avatar
      [Folder view] Use selected text color for selected items in full representation · a9291006
      Nate Graham authored
      Summary:
      Right now, selected (not highlighted) items in the popup persist in using
      the default text color , which can result in readability problems for light
      themes that use a dark highlight effect.
      
      BUG: 414287
      FIXED-IN: 5.17.4
      
      Test Plan:
      Put a Folder widget in a horizontal panel, click it, hover the mouse over one
      of the items in the list, and then click.
      
      Before: {F7772272}
      
      After: {F7772271}
      
      No change or regressions for selected items in Folder View on the desktop.
      
      Reviewers: #vdg, #plasma, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25418
      a9291006
  4. 05 Nov, 2019 1 commit
  5. 27 Sep, 2019 1 commit
  6. 11 Sep, 2019 1 commit
    • Nate Graham's avatar
      [Folder View] Add subtle shadows to icons · 37469c7d
      Nate Graham authored
      Summary:
      Folder View items currently have shadows behind their labels, but not their icons.
      
      This patch adds a very subtle shadow for the icons as well, which improves contrast
      for some backgrounds and just looks classy IMO. :)
      
      FEATURE: 411607
      FIXED-IN: 5.17.0
      
      Test Plan:
      Before: {F7334103, size=full}
      After: {F7334104, size=full}
      
      Reviewers: hein, #plasma, #vdg, filipf, ndavis
      
      Reviewed By: #vdg, filipf, ndavis
      
      Subscribers: broulik, GB_2, cfeck, ndavis, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23803
      37469c7d
  7. 09 Mar, 2019 1 commit
  8. 05 Dec, 2018 1 commit
  9. 27 Nov, 2018 1 commit
    • Nate Graham's avatar
      [Folder View] improve label contrast against challenging backgrounds · 10278e79
      Nate Graham authored
      Summary:
      Currently the shadow behind Folder View items' labels is very subtle. This leads to poor contrast against wallpapers that are light-colored, visually busy, or both.
      
      This patch attempts to improve the situation by tightening up the shadow so that it looks more like a subtle, tasteful outline.
      
      BUG: 361228
      FIXED-IN: 5.12.8
      
      Test Plan:
      Folder View items against various wallpapers:
      {F6439459, size="full"}
      
      {F6439458, size="full"}
      
      {F6439463, size="full"}
      
      {F6439457, size="full"}
      
      {F6439456, size="full"}
      
      {F6439455, size="full"}
      
      {F6439454, size="full"}
      
      {F6439453, size="full"}
      
      {F6439452, size="full"}
      
      {F6439451, size="full"}
      
      Folder View items against the default wallpaper:
      {F6439449, size="full"}
      
      Reviewers: #plasma, hein, #vdg
      
      Reviewed By: #plasma, hein
      
      Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16968
      10278e79
  10. 19 Nov, 2018 2 commits
    • Eike Hein's avatar
      Revert unintended line · 45434737
      Eike Hein authored
      45434737
    • Eike Hein's avatar
      Compress calls to `updateSize` · ab26ebb1
      Eike Hein authored
      Summary:
      Repeater+Flow has no reliable way to transactionize/batch insertion,
      e.g. `Flow.positionCompleted` is useless in a function that can change
      the Flow's size, and transition events like populated and similar
      aren't available. Refactoring this to be a ListView isn't appealing
      because it would mean the code loses the property of being reused for
      both the bar and the popup, and therefore is well-tested already.
      
      This brings down the number of `updateSize` calls when opening the
      dialog for a group of five from five to one.
      
      BUG:400364
      
      Reviewers: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17006
      ab26ebb1
  11. 22 Oct, 2018 1 commit
  12. 20 Jul, 2018 1 commit
    • Kai Uwe Broulik's avatar
      [Folder View] Improve file name text rendering · 5fca2b32
      Kai Uwe Broulik authored
      GridView pads out its delegate to ensure a uniform grid. This, however, causes items to be placed on fractional pixels,
      leading to blurry rendering and uneven hinting.
      Instead of adjusting padding calculation to return whole pixels, which will again cause a gap at the right side of the screen,
      since there's 20 icons in a row, slightly shift the delegate contents to move them back to whole pixels.
      Moreover, DropShadow renders the entire item with a drop shadow, so keeping the Label visible results in two labels ontop of
      each other leading to bolder text.
      
      Differential Revision: https://phabricator.kde.org/D14234
      5fca2b32
  13. 18 Jul, 2018 1 commit
    • Nate Graham's avatar
      Give file and folder names a bit more room in Folder View · 02dadc40
      Nate Graham authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.
      
      CCBUG: 379432
      
      Test Plan:
      Before, normal-sized icons:
      {F5755097}
      
      After, normal-sized icons:
      {F5755128}
      
      Before: small icons:
      {F5755102}
      
      After, small icons:
      {F5755127}
      
      Reviewers: hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11358
      02dadc40
  14. 12 Jul, 2018 1 commit
  15. 15 Mar, 2018 1 commit
    • Nate Graham's avatar
      Give file and folder names a bit more room in Folder View · 8208d9b3
      Nate Graham authored
      Summary:
      Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.
      
      CCBUG: 379432
      
      Test Plan:
      Before, normal-sized icons:
      {F5755097}
      
      After, normal-sized icons:
      {F5755128}
      
      Before: small icons:
      {F5755102}
      
      After, small icons:
      {F5755127}
      
      Reviewers: hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11358
      8208d9b3
  16. 05 Feb, 2018 1 commit
    • Eike Hein's avatar
      Improve preview thumbnail quality · db42961a
      Eike Hein authored
      Summary:
      This patch does two things:
      
      * Instead of giving the KAbstractViewAdapter the actual icon size,
        we overprovision by giving it the size times two. This is because
        while we're deriving the grid view cell size from the icon size
        setting, it's not the actual size the thumbnails will be displayed
        at. Our IconItem is sized to almost fill the cell, and for image
        sources with non-square aspect ratios IconItem doesn't scale to
        the next icon size.
      
      * We set IconItem to do smooth scaling.
      
      While this results in lovely visual fidelity, I the performance
      impact is a concern. We're requesting twice as large thumbnails
      now, and we're doing more scaling work. However, thumbnail
      generation is async and doesn't slow down listing. There's also
      the possibility IconItem::smooth could have general performance
      impact unless things are smart enough not to scale when not
      necessary, which is hopefully the case.
      
      BUG:376848
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10223
      db42961a
  17. 06 Jan, 2018 1 commit
    • Zren (Chris Holland)'s avatar
      Slightly reduce vertical gutter width. · 5ae880f8
      Zren (Chris Holland) authored
      Removed 1 smallSpacing from the top and bottom padding of each cell.
      
      Allows more rows to fit on screen. Results in less goofy-looking
      vertical gutters with the default of two text rows (as most labels
      only have one, it's a lot of dead space on screen in the common case).
      
      Based on user feedback.
      
      Reviewers: #plasma, hein
      
      Differential Revision: https://phabricator.kde.org/D9201
      5ae880f8
  18. 23 Jun, 2017 1 commit
    • Eike Hein's avatar
      Fix clicking outside of preview popups to dismiss them corrupting mouse state · 20bf7ec1
      Eike Hein authored
      Summary:
      As a result of refactorings in 5.10, hoveredItem may not reflect the
      true cursor position when preview popups become involved. When inter-
      acting with an item's associated preview popup, it's still considered
      hovered. This needs to be taken into account when processing clicks,
      otherwise corrupted mouse state leads e.g. to inadvertendly opening
      a folder by clicking outside its preview popup to dismiss it.
      BUG:380982
      
      Reviewers: #plasma
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6247
      20bf7ec1
  19. 08 Jun, 2017 1 commit
  20. 22 May, 2017 2 commits
  21. 19 Apr, 2017 1 commit
    • Kai Uwe Broulik's avatar
      [Folder View] Fix backport of wrapping fix · 076091e8
      Kai Uwe Broulik authored
      There's no labelMetrics and even if there were, it has no implicitWidth.
      The code in master also said "label", not labelMetrics.
      Probably IDE auto-correct to blame.
      
      Fixes wrapping text in FolderView delegate...
      076091e8
  22. 13 Apr, 2017 1 commit
  23. 12 Apr, 2017 1 commit
    • Eike Hein's avatar
      Hoist the actions overlay out of the frame loader. · c5961c16
      Eike Hein authored
      Summary:
      This fixes a race condition causing the actions overlay to sometimes
      appear in the drag pixmap attached to the DND cursor, as grabToImage
      is run against the frame loader.
      
      Test Plan:
      We used to have a problem with the actions overlay not
      repositioning properly in popup Folder Views when switching them
      between list and icon view mode, which partly shaped the old code
      (the anchor state changes). I verified this didn't regress with the
      new simplified code.
      
      Reviewers: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D5309
      c5961c16
  24. 27 Mar, 2017 1 commit
  25. 10 Mar, 2017 2 commits
  26. 09 Mar, 2017 1 commit
  27. 02 Mar, 2017 3 commits
  28. 01 Mar, 2017 2 commits
    • Eike Hein's avatar
      Reduce the hitbox for regular icon hover. · 5995ea91
      Eike Hein authored
      Summary:
      This reduces the sub-rectangle within the delegate that reacts
      to pointer hover to wrap the icon and label more tightly, which
      makes doing rectangle selections - foiled by accidentally
      hover-activating an icon - much easier by giving it larger
      gutters between icons to start in.
      
      Subtly, it does _not_ change two other hitboxes:
      1. Once an icon is in hover state, it can still by dragged by
         grabbing it on any coordinate within the visible frame, as
         it will only become un-hovered once the frame is exited.
      2. For drag hover (e.g within spring loading) the hitbox is
         unchanged - the larger hotbox makes it easier to aim with
         e.g. a drag pixmap attached to the cursor.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4860
      5995ea91
    • Eike Hein's avatar
      Tighter Folder View item delegates. · 8422f020
      Eike Hein authored
      Summary:
      This patch reduces margins inside the item delegate. The most
      frequent piece of user feedback for Folder View is "Can you let
      me change the grid size?", and the background behind the question
      always turns out to be unhappiness with the large gutters between
      icons and not being able to fit more icons on the desktop. A
      casual comparison to other desktops (including past KDE versions)
      indicates icon delegates indeed tend to be tighter. This follows
      suit.
      
      On my screen, the desktop now fits 9 instead of 7 rows of icons,
      with similar gains on the horizontal axis.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4856
      8422f020
  29. 27 Feb, 2017 1 commit
    • Eike Hein's avatar
      Make the hover state optional. · c88e4bff
      Eike Hein authored
      This is desired by a downstream distro which doesn't want hover
      effects in Folder View, but can't remove the graphics from the
      theme without negatively impacting other UI.
      
      It should go into the 5.9 branch to allow them to ship 5.9.
      c88e4bff
  30. 10 Feb, 2017 2 commits
    • Eike Hein's avatar
      Remove the TextFix workaround for QML text mouse handling bug. · b893dc9a
      Eike Hein authored
      Summary:
      Cf.: https://codereview.qt-project.org/#/c/113758/
      
      This was merged into Qt v5.6.2 and this branch thus doesn't
      support Qt v5.6 for the time being.
      
      The textFix call in the onCompleted handler now shows up as one
      of the remaining hotspots in the delegate.
      
      Reviewers: broulik, #plasma
      
      Reviewed By: broulik, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4345
      b893dc9a
    • Eike Hein's avatar
      Greatly improve Folder View performance and mem usage. · 99c90305
      Eike Hein authored
      Summary:
      Profiling suggests that Folder View spends most of its time
      in delegate creation, which occurs en masse during various
      operations, e.g. scrolling the view or navigating folder
      hierarchy via popup dialogs or drill-down in list view mode.
      
      This patch makes FolderItemDelegate substantially cheaper
      by bringing down its child object count considerably via
      a number of techniques:
      * Moving things that don't need to be in the delegate outside
        of it (e.g. a Timer that can be shared, a Connections that
        does work that can be done outside the delegate and a very
        costly ColorScope that can be moved up in the hierarchy.
      * Lazy-loading the expensive FrameSvgItem only in states
        which require it to be shown.
      * Managing action button life time procedurally as they are
        only needed during hover and even then only under a host
        of other conditions (instead of using Loaders, to save
        objects).
      
      Previously, scrolling a 7x6 Folder View widget pointed at
      my /usr/bin was nigh-unusable, now it's very nearly all
      smooth. The desktop mode is a little slower (due to
      expensive drop shadows below text labels) but also benefits.
      
      This is a big refactor and needs more testing. In particular,
      the spring-loading behavior needs thorough checking due to
      code refactors.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4343
      99c90305
  31. 25 Jan, 2017 1 commit
  32. 05 Jan, 2017 1 commit
  33. 27 Dec, 2016 1 commit
    • Chinmoy Pradhan's avatar
      Add overlay(s) to icons in plasma folder view · 6ecfe6ed
      Chinmoy Pradhan authored
      With this patch icons in plasma folder view will be rendered with overlay(s) (only if necessary).
      This makes it easier to differentiate locked files/folders, symlinks, mounted drives etc, from regular files.
      
      REVIEW: 128683
      6ecfe6ed