1. 21 Nov, 2019 1 commit
  2. 20 Nov, 2019 2 commits
    • Bhushan Shah's avatar
      kcm/fonts: set initial settings correctly · 243d0b6d
      Bhushan Shah authored
      Summary:
      During initial load we check if certain settings are set or not, and if
      they are not set, we set it to rgb/slight (recommended settings by
      Plasma team).
      
      however state management of this is broken, previous flow was,
      
      - try to get configuration
      - if configuration is not available, set state to desired settings
      - set original state to current state value(!)
      - write configuration to the file once complete state is written (all
        other settings)
      
      This is fine, when setting is changing from something other then none or
      not-set. But if it is not-set, both original state and current state
      ended up being desired settings, which write function would happily
      ignore since it thinks config never changed.
      
      So, if we encounter not-set configuration, preserve that as a original
      setting to get configs written correctly.
      
      This patch on it's own have no visible effect, kcm is still broken due
      to lack of kcminit which writes correct configuration at startup, but
      this is one of obvious bugfix for follow-up patch series.
      
      Test Plan: with upcoming patch to add kcminit, it correctly applies rgb/slight
      
      Reviewers: #plasma, fvogt, davidedmundson
      
      Reviewed By: fvogt
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25140
      243d0b6d
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 47d17ebe
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      47d17ebe
  3. 19 Nov, 2019 2 commits
  4. 18 Nov, 2019 4 commits
  5. 17 Nov, 2019 3 commits
  6. 15 Nov, 2019 1 commit
    • Steffen Hartleib's avatar
      Improved Touch support for Kickoff · 0322d1a2
      Steffen Hartleib authored and Nate Graham's avatar Nate Graham committed
      Summary:
      - enabled touch scrolling in Kickoff
      - open the correct category in the application tab
      - open the context menu with touch (tapandhold gesture similar to Windows 10)
      - start drag action with touch similar to Windows 10
      
      BUG: 406359
      BUG: 406361
      FIXED-IN: 5.18
      
      Reviewers: #plasma, hein, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: niccolove, khuoman, mart, sbergeron, davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21829
      0322d1a2
  7. 14 Nov, 2019 2 commits
  8. 13 Nov, 2019 3 commits
  9. 12 Nov, 2019 4 commits
  10. 08 Nov, 2019 2 commits
  11. 06 Nov, 2019 1 commit
    • Weng Xuetian's avatar
      [kimpanel] Add place holder button if everything is hide. · 7411258c
      Weng Xuetian authored
      Currently, if there is only one button from input method, it is
      sometimes impossible to hide any button, because the menu popup may
      cause lost of focus and button changes as soon as you right click the
      menu. The original logic is to prevent hide all the buttons, but since
      we now have placeholder, we can just simply hide any button.
      7411258c
  12. 05 Nov, 2019 4 commits
    • Nate Graham's avatar
      [Folder View] Use an inactive highlight effect when something else has focus · 596f979d
      Nate Graham authored
      Summary:
      The theme SVG doesn't have a concept of "inactive selection highlight", so we need to
      manufacture our own by reducing the opacity of the selection highlight.
      
      Thanks to @broulik for suggesting the necessary code changes in the bug report.
      
      FEATURE: 375501
      FIXED-IN: 5.18.0
      
      Test Plan: {F7743147}
      
      Reviewers: #plasma, #vdg, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25160
      596f979d
    • Konrad Materka's avatar
      [Touchpad applet] Close query dialog on focus loss · 76d9233b
      Konrad Materka authored
      Summary:
      Popup asking whether touchpad should be disabled stays open and can be covered by others, for example volume slider.
      It is inconsistent since other elements of tray close themselves after switching away.
      
      Depends on: D24825
      
      BUG: 401016
      
      Test Plan:
      1. Disconnect all mouses
      2. Click the touchpad icon
      3. Try to dismiss it like every other tray plasmoid, for example by clicking on some other window.
      4. Popup should consider itself dismissed
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25158
      76d9233b
    • David Edmundson's avatar
      [emojier] Load locale file correctly · f2d8a2f5
      David Edmundson authored
      Summary:
      ibus installs with the file en_GB.dict same with an underscore as a
      separator for all regional variants.
      
      The bcp47 name uses a hyphen.
      
      Test Plan: I see emoticons
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25156
      f2d8a2f5
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 6569912f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      6569912f
  13. 04 Nov, 2019 3 commits
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · d943a160
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      d943a160
    • Bhushan Shah's avatar
      kcm/fonts: Do not load image preview before loading settings · 0b8ef770
      Bhushan Shah authored
      Summary:
      The way image preview works is it tries to actually "set" and then
      "reset" the original value to render the text.
      
      However if we don't have default or user set settings loaded, it will
      reset it back to "NotSet" in end instead of user set value and this is
      not what we want.
      
      Test Plan:
      this alone is not enough to make kcm save subpixel properly
      but this is part of patch series
      
      Reviewers: davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25090
      0b8ef770
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 92b4eacc
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      92b4eacc
  14. 03 Nov, 2019 2 commits
  15. 02 Nov, 2019 2 commits
  16. 31 Oct, 2019 4 commits
    • Björn Feber's avatar
      [Task Manager] Toggle mute when the audio indicator is clicked · da268696
      Björn Feber authored
      Summary:
      The task manager shows an indicator on tasks playing audio (when
      enabled in the settings). This patch adds the ability to mute/unmute
      an application playing audio by clicking on the audio indicator in
      the task manager.
      
      Test Plan:
      * Check "Mark applications that play audio" in the Task Manager Settings
      * Open an application that plays audio
      * Click on the audio indicator and it should toggle the mute state
      {F7324364}
      
      Reviewers: #plasma, #vdg, ngraham, filipf, hein, faridb
      
      Reviewed By: #plasma, #vdg, ngraham, hein
      
      Subscribers: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19822
      da268696
    • Kevin Ottens's avatar
      Fix reset to defaults in the fonts KCM · 7b0149c7
      Kevin Ottens authored
      Summary:
      Turns out one of the properties was utterly broken emitting the wrong
      signal, and the defaults() method was missing a piece of state to reset.
      
      Since it was making my eyes bleed I also removed the "const int &"
      parameters in the process. :-)
      
      Reviewers: #plasma, bport, davidedmundson, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25094
      7b0149c7
    • Nate Graham's avatar
      [containments/desktop] Delete the "Tweaks" page and its options · 69d649e5
      Nate Graham authored
      Summary:
      With the new global edit mode, both of the options on the Tweaks page become unnecessary:
      - The option to hide the toolbox becomes dangerous because it breaks global edit mode
      - The option to toggle press-and-hold is unnecessary with the far superior global edit mode
      
      Test Plan:
      - Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list: {F7687032}
      - Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
      - You can no longer turn off the toolbox and break edit mode
      - You can no longer toggle the press-and-hold checkbox to show widget handles by hovering over widgets for a few seconds
      
      Reviewers: mart, GB_2, #plasma, hein
      
      Reviewed By: mart, #plasma
      
      Subscribers: fabianr, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10402
      
      Differential Revision: https://phabricator.kde.org/D25055
      69d649e5
    • Mikhail Zolotukhin's avatar
      Notify about change after cursor config is saved · cf7254a7
      Mikhail Zolotukhin authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Before that patch the cursor change signal was only transmitted after
      a configuration was applied on a fly. Because the cursor change is
      not applied on a fly on Wayland session yet, the signal is not emitted and
      therefore users of that signal are not notified about cursor change.
      
      Now the signal is emitted after the configuration save, so its users are
      notified.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24701
      cf7254a7