GitLab

There's no need since the custom delegate was manufacturing the exact
same look that a Kirigami.BasicListitem can provide with the hidden
separator setting. However this commit does not use that setting, so as
a result the separators now become visible. This makes the list
consistent with other lists in QML-based software.

My sense is that the reason why we hid the lines in the past was
because the lines had a very heavy appearance, but that was improved
recently to look much more lightweight.

includes() compares for equality, two objects are only equal if both reference
the same object. The active task model index is not necessarily the same as the
indx corresponding to it in the list because they are created seperately.
Alternatively we can just check if some index in the list is active.

Unfortunately are components free to choose their unique component name any way
they like, that means we have no chance to reasonably map a KService/icon to a
component if its identifier is chosen badly. For presentation purposes we can
at least hardcode some icons for components that are active in a default plasma
session.
CCBUG:424197
CCBUG:424198
CCBUG:424194
CCBUG:424195

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This commit adds tooltips to font settings for which the label alone isn't
sufficient for laymans to understand their effect. Similar explanations
were previously available in the form of "What's This?"-help but got lost
in commit R119:24b960f9: "QML port of fonts kcm" perhaps because
tooltip functionality was not readily available at the time. The
tooltips added here are partly based on these older ones.

The tooltips are invoked by either hovering or clicking flat Contextual
Help Buttons. This way the available help is unintrusively visible and
can be easily invoked on touch devices.

BUG: 422170

While there's not a graceful way to discern between user cancellation and an actual error,
the former is more likely so we bail out when encountering an error.

BUG: 422175

This is ultimately the sanest default as it provides the quickest way to
perform the two most common actions for grouped tasks: switching to the
last-used one, or hunting through all of them to find the one you want.
The "Cycle through task" option allows you to perform both actions with
clicks on the same icon, meaning that you don't have to move your cursor
or your visual focus compared to using any of the other three methods.

CCBUG: 370258

This implements a fairly common feature request to cycle through grouped
tasks when clicking on the group. There are two behaviors depending on
the active currentlytask:

- If the currently active task is not among the tasks of the clicked-on
  app/grouped task, then the most-recently used task in the group is
  brought forward.
- Otherwise, the next task in the group is brought forward, ignoring the
  stacking order, and instead going by the order of the indexes in the
  tasks model. This is deliberate; cycling through all tasks according
  to stacking order does not work because the stacking order changes
  every time a task is. Not using the stacking order for this case
  preserves the cycle order to improve the user's muscle memory when
  cycling through a large number of tasks.

As a result, it becomes ixtremely simple to switch between two
recently-used windows belonging to different apps when one or both
are within groups. With this mode, it takes only a single click. And
switching between multiple tasks of the same app likewise becomes simple
since you don't have to move your cursor from the grouped task icon;
instead you just keep clicking until you find the task you want.

FEATURE: 370258
FIXED-IN: 5.20.0

The Orca screen reader works on Wayland, so allow
to enabled/disable and configure it in the KCM when
in a Wayland session as well.

This removes the restriction that kcmaccess was only
available on X11/XCB, yet disables all tabs except
the screen reader one, since the other features
that could be configured didn't seem to work in a
quick test on Wayland.

BUG: 414546

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- All controls are moved to a header (more in line with other applets)
- Sidebar is wider to accomodate the rearranged layout
- Delete and running count are only shown on hover (more in line with the presentation used in KCMs)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Currently we get many complaints about the behavior of clicking on
grouped tasks, especially for the Icons-Only Task Manager, where the
Present Windows effect is always used when available.

This commit overhauls what happens when you click on a grouped task to
offer three options:
1. Show tooltips (new default setting)
2. Show Present Windows effect
3. Show textual list (AKA group dialog)

The user is now free to choose in the settings window which visualization
best suits them.

This commit does not implement the most heavily-requested option--to
bring forward all of the windows belonging to a grouped task
(https://bugs.kde.org/show_bug.cgi?id=370258)--as it is still blocked by
some technical isues related to stacking order and outstanding UX
uncertainty regarding what should happen when one or more of the windows
in a group happens to beminimized. However, since this commit introduces
a config UI for choosing the desired behavior when activating a grouped
task, there is now a place to put that option once it is implemented.

BUG: 424268
BUG: 390400
CCBUG: 370258
FIXED-IN: 5.20

Depends on frameworks/plasma-framework!39

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

They are now moved to plasma-workspace

They are moved to plasma-workspace.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This reverts commit f17eae91.

It was committed without adequate discussion and there were unresolved
discussions. Furthermore, no code review was done, and as a result it
shipped with visual regressions.

We will re-discuss and commit a fixed version if appropriate.

Locations are folders. Set the appropriate hint in order to get folder dialogs.

BUG: 424438
FIXED-IN: 5.18.6

GTK configuration in Plasma depends on xsettings daemon, that has no
separation between GTK2 and GTK3 theme, therefore separate themes for
GTK2 and GTK3 are impossible, while this daemon is working. The daemon
itself provides the functionality to apply settings to GTK applications
without restarting them.

The functionality to apply different themes to applications, depending on
the framework version isn't necessary, when 99% of the themes are
compatible with both versions and when most of the applications are
using the last GTK version anyway.

Given all that, I think, that a theme selection must be narrowed to one
and only one theme for both versions of the GTK framework.

CCBUG: 423141

See plasma-workspace!161

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This supports the conclusion in https://phabricator.kde.org/T13401

Fixes duplicate breeze entry after installing a cursor theme from a local file.

CCBUG: 421329

Seems like a sensible enough thing to focus by default, and additionally
right now nothing is focused by default so it's unclear where the
keyboard focus begins.

BUG: 423974
FIXED-IN: 5.20

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This is a more generic term that's less likely to be inappropriate
(every document is a file, but not every file is a document) and using
"Recent Files" brings Plasma into consistency with what KIO and Dolphin
call it.

BUG: 424007
FIXED-IN: 5.20