Plasma Desktop merge requestshttps://invent.kde.org/plasma/plasma-desktop/-/merge_requests2021-12-16T17:04:17Zhttps://invent.kde.org/plasma/plasma-desktop/-/merge_requests/752SwitcherBackend: Only create the workaround window on wayland2021-12-16T17:04:17ZDavid RedondoSwitcherBackend: Only create the workaround window on waylandNot needed on XNot needed on X5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/690Re-add Touchpad applet in safe read-only form2021-11-16T16:50:17ZNate GrahamRe-add Touchpad applet in safe read-only formI removed the applet entirely in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/455 to fix multiple bug reports related to people bricking their laptops by accidentally disabling their touchpads without a mouse handy, leav...I removed the applet entirely in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/455 to fix multiple bug reports related to people bricking their laptops by accidentally disabling their touchpads without a mouse handy, leaving them with no way to re-enable touchpad input.
However in retrospect, removing the applet entirely was too heavy-handed, as it can serve a
valid purpose as a status notifier to remind people who have manually
disabled their touchpads that they have done so. The problem was always the fact that you can use it to disable the touchpad.
The two commits of this MR re-add the applet, and then make it into a simple reas-only status notifier that shows you when the touchpad has been disabled, but does not let you do so yourself. This makes the applet safe enough to keep in upstream code.
This is deliberately done in two commits so that people or distros that absolutely hate the applet being read-only can revert 294507de4a19218032402662ec6cfabc47f7e77b to get the applet back into its original unsafe yet more feature-full state.
I'd like to get this into Plasma 5.23.4 if possible. No new translations are added compared to the state of the applet in Plasma 5.22.5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/682kickoff: Do not accept stylus in TapHandler2021-11-08T04:42:46ZFushan Wenkickoff: Do not accept stylus in TapHandlerWhen using a stylus, TapHandler will block KickoffItemDelegate from
receiving click events.
BUG: 445111When using a stylus, TapHandler will block KickoffItemDelegate from
receiving click events.
BUG: 4451115.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/681keyboardlayout: Fix missing Esperanto flag icon in the menu2021-11-08T16:35:07ZFushan Wenkeyboardlayout: Fix missing Esperanto flag icon in the menuBUG: 445077BUG: 4450775.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/657foldermodel: Drop overlay(s) to icons in plasma folder view2021-10-28T17:54:08ZFushan Wenfoldermodel: Drop overlay(s) to icons in plasma folder viewThe overlay is already handled by KDirModel after https://invent.kde.org/frameworks/kio/-/commit/c88c4c65567ed089902848b58aa62cd6563dd933
BUG: 444514
This MR reverts https://invent.kde.org/plasma/plasma-desktop/-/commit/6ecfe6edea41289...The overlay is already handled by KDirModel after https://invent.kde.org/frameworks/kio/-/commit/c88c4c65567ed089902848b58aa62cd6563dd933
BUG: 444514
This MR reverts https://invent.kde.org/plasma/plasma-desktop/-/commit/6ecfe6edea412896e948ea5a56abfa2846f380185.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/632[Folder View] Fix executing file without prompting2021-10-25T14:53:39ZEugene Popov[Folder View] Fix executing file without promptingWhen executing file without prompting, make sure it's a desktop file.
BUG: 435560When executing file without prompting, make sure it's a desktop file.
BUG: 4355605.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/627Fix issues with LayoutManager.insertAtCoordinates2022-02-07T12:01:13ZAlexander LohnauFix issues with LayoutManager.insertAtCoordinatesBUG: 444071BUG: 4440715.23Alexander LohnauAlexander Lohnauhttps://invent.kde.org/plasma/plasma-desktop/-/merge_requests/626Remove defunct check for proxyAction in foldermodel2021-10-21T19:49:34ZAlexander LohnauRemove defunct check for proxyAction in foldermodelIf we press the shortcut directly on the desktop the proxy action is still the del action,
because the context menu was not opened and the selection did not change after we pressed shift.
If we have the context menu open the proxyAction...If we press the shortcut directly on the desktop the proxy action is still the del action,
because the context menu was not opened and the selection did not change after we pressed shift.
If we have the context menu open the proxyAction is properly updated.
TestPlan:
Pressing delete with selected fle opens "Move to trash" dialog
Pressing shift+delete with selected file opens "Delete Permanently" dialog
Same with the context menu open.
BUG: 444128
@ngraham @derek5.23Alexander LohnauAlexander Lohnauhttps://invent.kde.org/plasma/plasma-desktop/-/merge_requests/625Fix pinned applet closes2021-10-21T16:21:30ZEugene PopovFix pinned applet closesCheck if the applet is pinned before closing it.
BUG: 443589Check if the applet is pinned before closing it.
BUG: 4435895.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/624Fix updating apps model2021-10-21T16:56:22ZEugene PopovFix updating apps modelThere is no need to check if the model of the current item is not empty, since the current item may be not only a category.
BUG: 444101There is no need to check if the model of the current item is not empty, since the current item may be not only a category.
BUG: 4441015.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/623taskmanager: Show highlight before ToolTipInstance starts loading for grouped...2021-10-24T13:06:03ZFushan Wentaskmanager: Show highlight before ToolTipInstance starts loading for grouped tooltipsFor grouped tooltips, if there are many windows in a group, it could
take a long time before all ToolTipInstances are loaded.
Show highlight before ToolTipInstance starts loading to make user feel
less unresponsive.
Note: Will not work...For grouped tooltips, if there are many windows in a group, it could
take a long time before all ToolTipInstances are loaded.
Show highlight before ToolTipInstance starts loading to make user feel
less unresponsive.
Note: Will not work when a tooltip is already visible (move directly from a task to a grouped task)
CCBUG: 433907
![highlight-first](/uploads/46a341c6df2d1c401d1808b5fadb5a79/highlight-first.mp4)5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/622taskmanager: Prevent useless component creation/destruction for grouped tooltips2021-10-24T13:06:02ZFushan Wentaskmanager: Prevent useless component creation/destruction for grouped tooltipsThe binding of `model` property of `DelegateModel` in ToolTipDelegate.qml
will trigger useless component creation/destruction when `rootIndex` is
changed but is not undefined. Make the ternary operator depend on
`hasRootIndex` bool prope...The binding of `model` property of `DelegateModel` in ToolTipDelegate.qml
will trigger useless component creation/destruction when `rootIndex` is
changed but is not undefined. Make the ternary operator depend on
`hasRootIndex` bool property to avoid that.
In Task.qml, only assign different values to `parentTask` and `rootIndex`
to avoid unnecessary component creation/destruction for the second time
hovering on the same task.
CCBUG: 433907
CCBUG: 444001
![prevent-useless-component-creation-destruction](/uploads/6f4c275a04e5c2cb20b9eaa0f3cf9c54/prevent-useless-component-creation-destruction.mp4)5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/621kickoff: Fix drag and drop causing delegates to reset to a 0 X position and o...2021-10-24T22:06:17ZNoah Daviskickoff: Fix drag and drop causing delegates to reset to a 0 X position and overlapBUG: 443975BUG: 4439755.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/612Set Qt.ImhNoPredictiveText for text fields that act as search fields2021-10-19T19:26:38ZArjen HiemstraSet Qt.ImhNoPredictiveText for text fields that act as search fieldsThis ensures that searching happens while the text is being entered from
a virtual keyboard.
BUG: 439914
See also https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1127This ensures that searching happens while the text is being entered from
a virtual keyboard.
BUG: 439914
See also https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/11275.23Arjen HiemstraArjen Hiemstrahttps://invent.kde.org/plasma/plasma-desktop/-/merge_requests/607Fix create-folder-shortcut (F10)2021-10-19T14:43:55ZDerek ChristFix create-folder-shortcut (F10)The create folder shortcut worked as long as the user did not right-
click into an empty space on the desktop to invoke the context menu.
The problem was that the create-folder-action was set to not visible
so that it is not shown in th...The create folder shortcut worked as long as the user did not right-
click into an empty space on the desktop to invoke the context menu.
The problem was that the create-folder-action was set to not visible
so that it is not shown in the context menu. But as soon as the context
menu is opened, the action is set to not visible in the plasmoid
contextual action list. The reason it works before opening the menu is
because the action for the plasmoid is created without setting it to
not visible.
This commit fixes the bug by using an already existing workaround class
that uses an event filter to respond to the
KStandardShortcut::createFolder key sequence.
BUG: 4435125.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/606Fix "clear emoji history" action2021-10-18T18:46:49ZNate GrahamFix "clear emoji history" actionIt wasn't saving the cleared config entry to the config file, so any
changes to the view (i.e. to make all the emojis disappear) would be
un-done when you closed the window and then re-opened it.
BUG: 443974
FIXED-IN: 5.23.1
cc @apolIt wasn't saving the cleared config entry to the config file, so any
changes to the view (i.e. to make all the emojis disappear) would be
un-done when you closed the window and then re-opened it.
BUG: 443974
FIXED-IN: 5.23.1
cc @apol5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/602taskmanager: Disconnect from backend.showAllPlaces on destruction2021-10-18T16:12:11ZFushan Wentaskmanager: Disconnect from backend.showAllPlaces on destructionThe slot function explicitly connected to showAllPlaces should be
disconnected manually on destruction.
BUG: 443820The slot function explicitly connected to showAllPlaces should be
disconnected manually on destruction.
BUG: 4438205.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/598[applets/kicker] Explicitly set visible property when opacity is 02021-10-14T17:26:13ZDavid Edmundson[applets/kicker] Explicitly set visible property when opacity is 0The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.
Enabled was used (presumably) to ensure that only the active
representation gets input events.
Unfortunate...The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.
Enabled was used (presumably) to ensure that only the active
representation gets input events.
Unfortunately this has a side effect. When switching views the icons on
the inactive view all get enabledChanged events. This triggers a redraw
with a greyed out effect on all icons. This is a very slow path,
especially for something not even visible!
Setting visible also stops input events, without the side effect.
Verified with qDebug in IconItem::polish5.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/594Make tooltip interactive when there is a player but no window is present2021-10-18T16:16:48ZFushan WenMake tooltip interactive when there is a player but no window is presentIf a media player is pinned to Task Manager, after opening the media
player and switching to another virtual desktop, the media controller
will be still visible in the tooltip but cannot be interacted with.
Move `hasPlayer` property to ...If a media player is pinned to Task Manager, after opening the media
player and switching to another virtual desktop, the media controller
will be still visible in the tooltip but cannot be interacted with.
Move `hasPlayer` property to ToolTipDelegate.qml, and add
`mainItem.hasPlayer` to `interactive` property of ToolTipArea to fix the bug.
BUG: 4434255.23https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/591Make clicking one item when multiple are selected deselect everything else in...2021-10-15T13:13:22ZBharadwaj RajuMake clicking one item when multiple are selected deselect everything else in desktop Folder ViewThis is handled in onReleased so as to distinguish between a drag and
click.
BUG: 424152This is handled in onReleased so as to distinguish between a drag and
click.
BUG: 4241525.23