Skip to content

[applets/kickoff] Fix compact representation centering on specific sizes

ivan tkachenko requested to merge work/ratijas/line-up into master

[applets/kickoff] Fix compact representation centering on specific sizes

Fixes drift toward bottom that may occur at specific applet sizes, such as with 64px tall panel and 150% global scaling on X11 for me.

Firstly, make the text label completely invisible when it has no text, thus avoiding extra spacing added by RowLayout.

Secondly, setting fontSizeMode to Text.VerticalFit makes sense only and only if the component itself is constrained vertically, which is the job for Layout.fillHeight property.

Lastly, set icon's Layout.alignment too, just in case.

Kickoff_icon_drifting_down

[applets/kickoff] Fix compact representation's icon's active property

The binding got broken in a recent refactoring. It was dynamically referring to a MouseArea's containsMouse value via a generic parent property. Accessing it by id is more robust and future-proof.


Actually I didn't notice any visual difference between 'active' and 'inactive' states. Not sure about it. But code-wise it's a textbook example why you shouldn't use parent property for everything.

Merge request reports

Loading