Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 53
    • Merge requests 53
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !1253

Add an 'Add Command' button to the Shortcuts KCM

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bharadwaj Raju requested to merge work/bharadwaj/shortcuts-kcm-addcommand into master Nov 16, 2022
  • Overview 58
  • Commits 26
  • Pipelines 32
  • Changes 7

Replacement for !1189 (closed). This time a separate dialog which doesn't involve KIO.

After reading a good amount of feedback and questions from users, it seems that it is not clear that the textbox in the "Add Application…" dialog can be used to add custom commands.

Some examples of user confusion that I found:

  • https://old.reddit.com/r/kde/comments/xw8k06/the_new_shortcut_page_in_wayland_is_a_big/
  • https://old.reddit.com/r/kde/comments/x0tmr5/custom_keyboard_shortcut_to_run_command/
  • https://old.reddit.com/r/kde/comments/xf59gs/how_do_i_create_a_custom_shortcut/
  • https://old.reddit.com/r/kde/comments/xf4a3g/global_mappings/
  • https://www.reddit.com/r/kde/comments/xe59pe/custom_shortcuts_disappeared_in_system_settings/

This MR adds a separate button to add a command, which opens an overlay sheet:

image

image

cc @teams/vdg @teams/usability

BUG: 460036 BUG: 440431 FIXED-IN: 5.27

Edited Nov 17, 2022 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/bharadwaj/shortcuts-kcm-addcommand