Skip to content

Mark KCM only as dirty when config should be saved

Alexander Lohnau requested to merge (removed):runner_reload_event into master

This was introduced with https://phabricator.kde.org/D26445.

Connect configCommitted to ensure "Apply" gets enabled when you change any of the runner plugin settings.

I disagree with that. The saving of the individual runner KCMs is independent of the saving of the plugin selector.

The current behavior also suggests that you have to save the runners KCM and also the plugin selector for the config to be persisted, which is not true.

Also if you disable and then enable the plugin you can't click apply, because the changed parameter of the changed event is set to false. This parameter was ignored when the markAsConst method was used.

Edited by Alexander Lohnau

Merge request reports