Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !272

WIP: Fix mailto: links if Thunderbird is the default

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Fabian Vogt requested to merge work/fixthunderbird into master Dec 17, 2020
  • Overview 21
  • Commits 1
  • Pipelines 0
  • Changes 1

After d1f62c16 ("KCM/Component Revamp email config"), the EmailClient in .config/emaildefaults contains a path to a .desktop file instead of the executable. This is not compatible with what xdg-mime does:

local client=$($kreadconfig --file emaildefaults \
                            --group "PROFILE_$profile" \
                            --key EmailClient \
                      | cut -d ' ' -f 1)

if echo "$client" | grep -Eq 'thunderbird|icedove'; then
    run_thunderbird "$client" "$1"
fi

It's not easily possible to map a .desktop file to an executable which can be called that way, but fortunately it doesn't seem like "EmailClient" is used anywhere anymore and the fallback in xdg-email is actually working fine. So just delete the key if it's set.

WIP because I didn't actually test this code directly, I only played around with the config files directly.

CC @meven

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fixthunderbird