Skip to content

applets/kicker: make dash/grid keynav not broken in RtL

Christoph Wolk requested to merge cwo/plasma-desktop:kicker_grid_nav_rtl into master

Arrow key navigation in dashboard/grid view is currently completely broken, and not just in a "arrow keys go the wrong direction" way, due to the complex way that multiple grids work and various components taking LtR into account or not.

This change at least makes it function somewhat reasonably.

Test plan:

  1. plasmawindowed org.kde.plasma.kickerdash --reverse, click the window to open dash
  2. Arrow-key around for a bit
  3. (without patch) It's absolutely awful
  4. (with patch) It's not awful

It's still somewhat confusing code, which isn't helped by kickerdash being somewhat mirrored in its keyboard operation (in LtR, the multiple grids are arranged RtL and initial focus is on the right, but the grids themselves are LtR, so renaming the signals would also be confusing). If someone at some point decides to really care about kickerdash again, this should be reworked to be less confusing. But until then I think it's better to ship something that's not completely broken.

Merge request reports