Skip to content

applets/taskmanager: handle null playerData when switching tooltip

Christoph Wolk requested to merge cwo/plasma-desktop:task_tooltip_player_null into master

The tooltips conditionally load the player controls depending on whether the playerData property is set, and the controls also access this property. This leads to a race condition when changing the hovered app while the tooltip is showing and the tooltip goes from actual playerData to null: if the Loader stops noticing the changed property first all is well, but if the PlayerController notices it first, it spews a slew of TypeErrors before being unloaded.

Instead, we guard against null playerData and set appropriate values in those cases so the unloading of the PlayerController can always happen gracefully.

This doesn't always happen; I've found it easiest to trigger with preview-less tooltips but more rarely it can happen with tooltips containing previews as well.

Merge request reports