Skip to content

desktoppackage/configuration: simplify containment config loading

Christoph Wolk requested to merge cwo/plasma-desktop:no_configurationappletpage into master

The two global containment configuration pages (Wallpaper and Actions) still use the old loading method, which is essentially a copy of the regular method that also wraps them inside a page and adds an extra configuration flag. This makes the whole structure more complicated and harder to modify.

Instead, convert the two pages to use KCMUtils base classes and load them the usual way.

The Folder View configuration pages are still loaded as containments (or in the case of panel Folder Views, are incorrectly loaded with the default config page loader, which causes them to not have page headers). With the containment-specific loaders gone, these need to be switched to KCMUtils components rather than arbitrary items as their base.

This change switches them to SimpleKCM or ScrollViewKCM as appropriate.

I tested that the new ones work and are displayed correctly. For a small sample I also tested proper config writing.

(The select all/unselect all buttons in ConfigFilter do not work, but this is a pre-existing issue)

ConfigFilter has a lot of changes, but it's mostly indentation to fit ScrollViewKCM rather than have everything in a layout.

Merge request reports