applets/{kicker,kickoff}: put favorites actions next to "add to" actions

Reason for the change

From a user's standpoint, "Add to Desktop", "Pin to Task Manager", and "Add to Favorites" are all the same kind of actions, but currently they are placed quite far from each other. The reason seems totally technical (because the first two are defined in plasma-workspace in libkicker while the favorites action is set up in the applets from QML/JS and added with a simple push).

This MR puts the favorites actions right after the "Add to Desktop" or "Pin to Task Manager" (or Add to Panel if it exists for some reason) instead.

(For reference, the "add to" actions are created in plasma-workspace's applets/kicker/actionlist.cpp. Their action IDs are addToDesktop, addToTaskManager, and addToPanel respectively, which seems weird (no prefix) but this seems to just be how it is.)

Test plan

Right click an app in Kicker (Application Menu), Kickoff (Application Launcher), or Kickerdash (Application Dashboard) If these changes work as intended, the favorites action(s) should be located next to the add to desktop actions.

These changes do apply to Application Dashboard.

Screenshots or screen recordings

Before After
kicker-before kicker-after
kickoff-before kickoff-after
kickerdash-before kickerdash-after

Bugs fixed

No one seems to have opened a ticket about this yet.

Edited by Kisaragi Hiu

Merge request reports

Loading