Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 43
    • Merge requests 43
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !537

[containments/desktop] Fix applet overlay icon size with touch interaction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-desktop:fix-applet-config-overlay-icon-size-with-touch into master Aug 04, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Ths intention of this code was to present larger icons when the config overlay was shown via a touch event. However this did not work because the buttons' size was accidentally hardcoded to small, with conflicting size definitions when only one was needed.

This commit fixes the issue by removing the width and height properties, using the correct layout properties, and allowing the icon size to scale ccording to the space available, which fixes the problem for touch. There are no visual changes with the mouse-based interaction.

Here's how it now looks when tapped-and-held with a finger:

Screenshot_20210803_230530

cc @thiagosueto

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-applet-config-overlay-icon-size-with-touch