From 7881fdf5df8d4ab184722ce077b2abe445cbf4df Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Thu, 14 Oct 2021 17:32:08 +0100 Subject: [PATCH] [applets/kicker] Explicitly set visible property when opacity is 0 The Dashboard representation contains 3 views stacked on top of each other with one visible at a time with an opacity animation. Enabled was used (presumably) to ensure that only the active representation gets input events. Unfortunately this has a side effect. When switching views the icons on the inactive view all get enabledChanged events. This triggers a redraw with a greyed out effect on all icons. This is a very slow path, especially for something not even visible! Setting visible also stops input events, without the side effect. --- .../kicker/package/contents/ui/DashboardRepresentation.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/applets/kicker/package/contents/ui/DashboardRepresentation.qml b/applets/kicker/package/contents/ui/DashboardRepresentation.qml index 777ab3312..520e47fab 100644 --- a/applets/kicker/package/contents/ui/DashboardRepresentation.qml +++ b/applets/kicker/package/contents/ui/DashboardRepresentation.qml @@ -569,7 +569,7 @@ Kicker.DashboardWindow { anchors.fill: parent z: (opacity == 1.0) ? 1 : 0 - enabled: (opacity == 1.0) ? 1 : 0 + visible: opacity != 0.0 property int headerHeight: mainColumnLabel.height + mainColumnLabelUnderline.height + PlasmaCore.Units.largeSpacing @@ -690,7 +690,7 @@ Kicker.DashboardWindow { width: parent.width height: systemFavoritesGrid.y + systemFavoritesGrid.height - enabled: (opacity == 1.0) ? 1 : 0 + visible: opacity != 0.0 opacity: filterList.allApps ? 1.0 : 0.0 @@ -731,7 +731,7 @@ Kicker.DashboardWindow { width: parent.width height: Math.min(implicitHeight, systemFavoritesGrid.y + systemFavoritesGrid.height) - enabled: (opacity == 1.0) ? 1 : 0 + visible: opacity != 0.0 model: runnerModel -- GitLab