Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !626

Remove defunct check for proxyAction in foldermodel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Lohnau requested to merge work/fix_shift_del_on_desktop into master Oct 21, 2021
  • Overview 3
  • Commits 1
  • Changes 1

If we press the shortcut directly on the desktop the proxy action is still the del action, because the context menu was not opened and the selection did not change after we pressed shift.

If we have the context menu open the proxyAction is properly updated.

TestPlan: Pressing delete with selected fle opens "Move to trash" dialog Pressing shift+delete with selected file opens "Delete Permanently" dialog

Same with the context menu open.

BUG: 444128

@ngraham @derek

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fix_shift_del_on_desktop