Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !742

containments/panel: Fix state when dragging gets canceled

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/panel-dragging-canceled into master Dec 12, 2021
  • Overview 5
  • Commits 1
  • Pipelines 8
  • Changes 1

In panel edition, when dragging an applet to reorder the layout, we were not handling the case when the dragging operation gets canceled.

Dragging cancelation can be triggered by pressing or other focus-intrusive operations like a delayed screenshot.

This led to an unconsistent state of the panel where the dragged applet would just stay out the layout, floating in the last position it was dragged to.

For now, acting on the canceled signal just as if the dragging was released seems the simpler to avoid a messed-up panel.

BUG: 446814

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/iasensio/panel-dragging-canceled