Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !809

[kcms/keyboard] Fix populating layouts when reloading config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fabian Vogt requested to merge work/fvogt/kde448381 into master Jan 19, 2022
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 1

Previously, it populated the internal list of layouts before reloading settings from kcfg. That lead to KCMKeyboardWidget::configureLayoutsChanged getting called for ticking the checkbox while the list of layouts was already nonempty, which is an invalid/unexpected state. In its confusion it cleared the list.

Just load kcfg settings first to avoid this.

BUG: 448381

CC @butirsky

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fvogt/kde448381