Commit ab007182 authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇

[Desktop Containment] Explicitly reject Firefox tab drops

This is a real-world fix for a long-standing issue.
Mime-type determination and everything is asynchronous, so we cannot know in advance
whether to accept or reject the drop.

BUG: 337711
FIXED-IN: 5.12.0

Differential Revision: https://phabricator.kde.org/D9640
parent 6ecd2e3c
......@@ -243,6 +243,12 @@ FolderViewDropArea {
if (isContainment && plasmoid.immutable && !(isFolder && FolderTools.isFileDrag(event))) {
event.ignore();
}
// Firefox tabs are regular drags. Since all of our drop handling is asynchronous
// we would accept this drop and have Firefox not spawn a new window. (Bug 337711)
if (event.mimeData.formats.indexOf("application/x-moz-tabbrowser-tab") > -1) {
event.ignore();
}
}
onDragMove: {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment