Commit b3044152 authored by David Edmundson's avatar David Edmundson

Avoid blocking DBus calls when extracting files

Summary:
When copying from Ark to the desktop we make a blocking DBus call,
freezing the entire UI.

We don't do anything with the reply, so lets not bother waiting for it.

Test Plan:
Ran Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 plasmashell
Copied something from ark to the desktop.
Still had the file, but didn't block

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8601
parent 7af16dc4
......@@ -945,7 +945,7 @@ void FolderModel::drop(QQuickItem *target, QObject* dropEvent, int row)
QStringLiteral("extractSelectedFilesTo"));
message.setArguments({dropTargetUrl.toDisplayString(QUrl::PreferLocalFile)});
QDBusConnection::sessionBus().call(message);
QDBusConnection::sessionBus().call(message, QDBus::NoBlock);
return;
}
......@@ -1006,7 +1006,7 @@ void FolderModel::dropCwd(QObject* dropEvent)
QStringLiteral("extractSelectedFilesTo"));
message.setArguments(QVariantList() << m_dirModel->dirLister()->url().adjusted(QUrl::PreferLocalFile).toString());
QDBusConnection::sessionBus().call(message);
QDBusConnection::sessionBus().call(message, QDBus::NoBlock);
} else {
Qt::DropAction proposedAction((Qt::DropAction)dropEvent->property("proposedAction").toInt());
Qt::DropActions possibleActions(dropEvent->property("possibleActions").toInt());
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment