Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit efd4c22b authored by Harald Sitter's avatar Harald Sitter 🌼

don't set a user if there is no user

Summary:
it doesn't have technical downsides but ends up creating urls of the type

scheme://@host/path

which is technically equal to scheme://host/path, so the excess @ is really
just not necessary. simply check if the username is empty and if so
do not set a username on the QUrl

Test Plan:
- no useless @
- setting up fish connection with and without username still works (without defaults to local username)

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16275
parent 53255b78
......@@ -201,7 +201,10 @@ bool KNetAttach::validateCurrentPage()
}
url.setHost(_host->text().trimmed());
url.setUserName(_user->text().trimmed());
const QString trimmedUser = _user->text().trimmed();
if (!trimmedUser.isEmpty()) {
url.setUserName(trimmedUser);
}
QString path = _path->text().trimmed();
#ifndef Q_WS_WIN
// could a relative path really be made absolute by simply prepending a '/' ?
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment