Commit f14afa94 authored by Nate Graham's avatar Nate Graham 🔩

[applet/taskmanager] Remove the launcher items' tooltip icons

Summary:
As discussed in T12778, the icon can never be in a correct state: either it's
redundant with the icon you're hovering over that made the tooltip appear, or
else it's different from the icon you're hovering over, which is inconsistent.
Furthermore, some instances of the tooltip have icons and others do not,
heightening the inconsistency.

Since either case is undesirable, let's just remove the icon from the tooltip
entirely. This reduces the visual noise in the tooltip and solves the entire
class of bugs automatically.

Test Plan:
{F8150018}
{F8150021}

Reviewers: #vdg, #plasma, niccolove, ognarb

Reviewed By: niccolove, ognarb

Subscribers: anthonyfieroni, plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D27847
parent f3bbc0ba
......@@ -73,7 +73,7 @@ ColumnLayout {
spacing: units.smallSpacing
// launcher icon + text labels + close button
// text labels + close button
RowLayout {
id: header
// match spacing of DefaultToolTip.qml in plasma-framework
......@@ -86,16 +86,6 @@ ColumnLayout {
// match margins of DefaultToolTip.qml in plasma-framework
Layout.margins: isWin ? 0 : units.gridUnit / 2
// launcher icon
PlasmaCore.IconItem {
Layout.preferredWidth: units.iconSizes.medium
Layout.preferredHeight: units.iconSizes.medium
source: !isWin ? icon : ""
animated: false
usesPlasmaTheme: false
visible: !isWin
}
// all textlabels
ColumnLayout {
spacing: 0
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment