Commit fd6f3bac authored by Mikhail Zolotukhin's avatar Mikhail Zolotukhin

[GTK Subpage] Hide Breeze Dark for GTK3

Given, that Breeze GTK grabs its colors from color scheme and Breeze
Dark doesn't do that creating by that confusion within the users, dark
theme should be hidden from the list of available GTK3 themes.

Keeping dark variant may be useful for other desktop environments where
there is no dynamic recoloring and there aren't any color scheme settings.

CCBUG: 413198

Test Plan: Check if the GTK3 combobox in Application Style > GNOME/GTK Application Style does not have the "Breeze-Dark" option.

Reviewers: cblack

Reviewed By: cblack

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision:
parent 785167f3
......@@ -60,6 +60,14 @@ void GtkThemesModel::loadGtk3()
// If the directory contains any of gtk-3.X folders, it is the GTK3 theme for sure
QDir possibleThemeDirectory(possibleThemePath);
if (!possibleThemeDirectory.entryList(gtk3SubdirPattern, QDir::Dirs).isEmpty()) {
// Do not show dark Breeze GTK variant, since the colors of it
// are coming from the color scheme and selecting them here
// is redundant and does not work
if (possibleThemeDirectory.dirName() == QStringLiteral("Breeze-Dark")) {
gtk3ThemesNames.insert(possibleThemeDirectory.dirName(), possibleThemeDirectory.path());
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment