1. 16 Jan, 2021 3 commits
  2. 15 Jan, 2021 1 commit
  3. 10 Jan, 2021 2 commits
  4. 05 Jan, 2021 1 commit
  5. 21 Dec, 2020 1 commit
  6. 20 Dec, 2020 2 commits
  7. 18 Dec, 2020 1 commit
  8. 17 Dec, 2020 1 commit
  9. 16 Dec, 2020 5 commits
  10. 05 Dec, 2020 2 commits
  11. 01 Dec, 2020 1 commit
  12. 19 Nov, 2020 1 commit
  13. 10 Nov, 2020 1 commit
  14. 09 Nov, 2020 1 commit
    • Harald Sitter's avatar
      actually erase devices · fd099a75
      Harald Sitter authored
      somebody forgot to actually erase 😞
      
      this would eventually result in a crash as the container would have
      dangling pointers as remove only moves around the entries so the
      container would be the same size before and after remove but one of the
      pointers would then get deleted in the eventloop
      
      BUG: 428746
      FIXED-IN: 5.20.3
      fd099a75
  15. 03 Nov, 2020 2 commits
  16. 27 Oct, 2020 1 commit
  17. 20 Oct, 2020 2 commits
  18. 18 Oct, 2020 1 commit
  19. 13 Oct, 2020 2 commits
  20. 09 Oct, 2020 7 commits
    • Harald Sitter's avatar
      fix device type check for freebsd · 95761dde
      Harald Sitter authored
      on freebsd there are only character devices. This is a bit meh because
      more than actual disks devices match this check but Adriaan knows no
      better options either short of what smartctl needs to do anyway, so we'd
      not win much by complicating matters on our end.
      95761dde
    • Harald Sitter's avatar
      replace open-fstat dance with lstat · 00659ebe
      Harald Sitter authored
      since we know the path cannot be relative because of the dir separator
      check there is no point in explicitly opening the path when we can
      instead pass it to lstat as-is. the path will be absolutely of the form
      /dev/foo so at most it could be a symlink that we'll not follow with
      lstat.
      00659ebe
    • Harald Sitter's avatar
      make O_PATH optional-ish · 65a91a53
      Harald Sitter authored
      on ancient linuxes we don't have access to it. more importantly freebsd
      has nothing like it at all. use readonly in these cases
      65a91a53
    • Harald Sitter's avatar
      add missing include for freebsd · 3c299d99
      Harald Sitter authored
      errno is implicitly pulled in on linux
      3c299d99
    • Harald Sitter's avatar
      pass device names to the helper · 6d2a5fc8
      Harald Sitter authored
      paths are somewhat trivial to exploit. instead resolve them to the
      actual block device names under /dev/ and pass that into the privileged
      helper. the helper then only needs to verify that $name is in fact a
      block device under /dev/.
      since unprivileged processes cannot create files in /dev/ directly, let
      alone block devices, this should give us a very reliable way of
      preventing abuse.
      6d2a5fc8
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 66efc179
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      66efc179
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 7aa73881
      Script Kiddy authored
      7aa73881
  21. 08 Oct, 2020 1 commit
  22. 05 Oct, 2020 1 commit
    • Harald Sitter's avatar
      add request queuing to kauth smartctl · 325018e2
      Harald Sitter authored
      kauth does not actually support making multiple requests at the same
      time.
      this effectively caused multiple devices to get the same reply blob
      based on which device gets requested first, rendering the data largely
      useless as they'd all reflect the state of a single device.
      
      since the kauth test is a bit rubbish to test data consistency is now
      asserted in the monitor
      
      ```
      e.g.
      ::run(/dev/nvme0n1) -> job0
      ::run(/dev/sda) -> job1
      
      |
      kauth makes single request to action
      |
      v
      
      helper(/dev/nvme0n1)
         			--> returns blob0
      
      |
      kauth returns all jobs for that action
      |
      v
      
      job0 -> result(blob0)
      job1 -> result(blob0)
      ```
      325018e2