1. 09 Oct, 2020 3 commits
    • Harald Sitter's avatar
      make O_PATH optional-ish · 65a91a53
      Harald Sitter authored
      on ancient linuxes we don't have access to it. more importantly freebsd
      has nothing like it at all. use readonly in these cases
      65a91a53
    • Harald Sitter's avatar
      add missing include for freebsd · 3c299d99
      Harald Sitter authored
      errno is implicitly pulled in on linux
      3c299d99
    • Harald Sitter's avatar
      pass device names to the helper · 6d2a5fc8
      Harald Sitter authored
      paths are somewhat trivial to exploit. instead resolve them to the
      actual block device names under /dev/ and pass that into the privileged
      helper. the helper then only needs to verify that $name is in fact a
      block device under /dev/.
      since unprivileged processes cannot create files in /dev/ directly, let
      alone block devices, this should give us a very reliable way of
      preventing abuse.
      6d2a5fc8
  2. 08 Jul, 2020 1 commit
  3. 23 Jun, 2020 1 commit
  4. 22 Jun, 2020 1 commit
    • Harald Sitter's avatar
      rejigger smartctl running a bit · 12945f20
      Harald Sitter authored
      the exit code of smartctl actually has meaning and we'll likely want to
      deal with it to construct more pertinent error messages I think.
      
      although, the code is apparently also reflected in the json so perhaps
      passing it along on its own isn't all that meaningful
      12945f20
  5. 10 Jun, 2020 1 commit