GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENT

json blobs like this would previously have been discard on account of
code 1 (invalid command line) since all exit codes now factor into
device validity we'll want to make sure that the monitor doesn't blow up
if it encounters a device with code 1 and consequently incomplete json
data

relates to 1f4ccf54

I have a wacky device here for which smartctl gives the error:
"/dev/sda: Unknown USB bridge [0x0781:0x5591 (0x100)]"

This returned JSON data is missing some expected entries, which
seems to give an invalid parsing result. In that case, skip it
*before* checking for any consistency with further expectations.

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Ensures it has a sane default size when opened via `kcmshell5 smart`

when SMART is disabled smartctl will exit0 but contain no smart_status
which means default values get used and the device is considered
invalid. since we don't know what the status is in this situation we'll
consider the entire data set invalid and thereby hide the device.

with the growing amount of potentially discarded (but present) data
blobs it might soon make sense to think about rendering invalid devices
in the KCM with an unknown state so people at least can find out that
their drives aren't being monitored

BUG: 435699
FIXED-IN: 5.22.0

everytime I saw the old code my heart wept

this fixes vbox drives getting reported as possibly breaking when indeed
they simply lack any amount of smart data. currently I have no evidence
that this is a more wide spread issue beyond vbox so the validity
condition is fairly constrained.

this also sees a slight refactor of smartctl which previously had error
some weak failure handling, by moving that outside the kauth-dependent
code we can actually test this though and smartmonitor is easily retro
fitted for validity handling anyway

CCMAIL: Alexander Lohnau <alexander.lohnau@gmx.de>

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

simulation.qrc isn't added to the build when WITH_SIMULATION is
disabled and thus building errors out with "undefined reference to
`qInitResources_simulation()'".

...Because in this case it's not used at all and generates a compiler
warning.

since our l10n scripts run with the assumption that the code is c++ we'd
not correctly support all javascripty strings that qml can do. notably
template literals, but also ""+\n"" multi-line strings

as it turns out there are a number of issues that do not result in an
actually bad SMART status and would not get reported to the user. to
keep the code lean we'll simply look at the exit code bits of smartctl
as they more or less cover all failure scenarios anyway. we'll then
translate those to pretty strings and expose them on the Device objects
for consumption in the qml KCM as "instabilities". they are set visually
apart from actual bad status through different icon and description
because it's hard to say if an instability is in fact indicative of
imminent hard-failure or merely a hiccup (e.g. power loss during a disk
operation).

BUG: 429804
FIXED-in: 5.22

- missing-status failed to retrieve data because ioctl timed out
- pass-freebsd is a passing check on freebsd (doesn't really differ from
linux)

since a hotfix that changed when exactly devices appear the
notifications have been broken as they'd never get emitted when the
failed property was already true when the deviceAdded signal fired (i.e.
pretty much always unless the state changed while the system was
running)

to fix this always try to notify on devices when they appear. if they
aren't failing we aren't raising notifications anyway

it's very tricky to actively test the UI because you can't just inject
arbitrary SMART data blobs.

this refactor seeks to remedy that by abstracting away the device
notification from solid and based on that implement a complete
simulation mode where both the device notifier (the bit enumerating
solid) and the ctl (the bit doing kauth + smartctl) are replaced by
mocking instances at runtime. these instances then use the data in the
fixture pool instead of actually looking at the active hardware on the
system. this effectively allows us to check how all the various fixtures
are actually handled by the actual production code.

for convenience more than anything this is on by default when building
in debug mode. also for convenience the fixtures are rcc'd into the
binary instead of looked up from disk (also relocatability is of course
always a concern)

(this actually reveals a problem with the notification tech: it doesn't
notify on devices that are failing ri...

GIT_SILENT

GIT_SILENT

GIT_SILENT

This makes it easier to build against both Qt5 and Qt6

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"