GIT_SILENT

GIT_SILENT

Jan Blackquill authored Apr 04, 2022 and Jan Blackquill committed May 30, 2022

When a QPlatformMenuBar has a nullptr parent; it's supposed to be
appwide (this is documented in public QMenuBar docs), so we now
make sure to register app-wide menubars for all windows that
don't already have a menubar of their own.

GIT_SILENT

GIT_SILENT

00fc43a2 enables hover effects by
default. The unit test was not updated.

Still QDBusPlatformMenu linking problem (not idea yet)

Even though use of QWaylandClientExtension has the registry initialsed
on startup, there's a quirk of extension that it doesn't create itself right away.

We've seen that windows can change palettes on startup before the
event loop has run.

BUG: 452060

This got lost because it was done in the registry slot

Otherwise the color scheme is not set on the initial call.

Kwin does not speak wayland to itself. Recent changes make use of
QWaylandClientExtension that understandably assumes the wayland QPA is
in use.

Kwin's QPA name "wayland-org.kde.kwin.qpa" matches the check
KWindowSystem::isPlatformWayland() which internally does
platformName.startsWith("wayland")

We have no reason to sync application colour schemes or appmenu bars to
kwin from inside the QPT, so we can just tighten our check for which QPA
is in use.

This helps with our plans for Plasma 6. There should be no user facing
changes.

This mainly includes build system changes and minor code changes, the only
still remaining issue is the D-Bus menu code. That compiles but fails to
link as the corresponding classes in Qt are not exported despite installed
(private) headers.

Qt might call `setDirectory` twice on dialog initialization, the second
one coming from `restoreFromSettings`.
This would needlessly trigger another `StatJob` if the URL didn't change.

This way we do not need to call this function manually and explicitly get the KDeclarative
dependency.

Also, this code is only relevant on the Linux platform.

Task: https://phabricator.kde.org/T12135

When for whatever reason ColorScheme from kdeglobals point to a nonexistant scheme then no entry for m_palettes[QPlatformTheme::SystemPalette] is created, leading to a crash down the line

Instead fall back to BreezeLight to avoid a crash

BUG: 449613

We don't want a palette for decorations on popups as they don't show a
decoration. We can't have an application menu on a popup.

Debug shows we are creating objects unnecessarily.

GIT_SILENT

GIT_SILENT

This is now correctly set up when inside a plasma session.

GIT_SILENT