Nicolas Fella authored Jul 31, 2022 and Alexander Lohnau committed Aug 01, 2022

It's not read by anything

it has no purpose

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This is consistent with bluedevil.

There are too many MouseAreas, and each will consume a little memory.
This uses childAt to reduce the number of MouseArea.

When they have focus, a highlight will appear.

This moves DetailsText to FocusScope, and gives FocusScope a
description.

Connect/Disconnect doesn't say which connection the button refers to.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

We exec() the dialog, which then deletes the dialog, and then access the dialog, which goes boom

Partially revert a5c43dd9 and delete the dialog manually again

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Additionally this ensures we always load the correct password option
since eapMethods may be empty.

This links together the "All users can connect" checkbox on the general
connection page to the "Storage password" combobox in the wireless
security page. When "All users can connect" is checked, we change things
so we store secrets system wide as well, as otherwise you end up with a
connection that does not contain secrets, which makes it rather hard to
use a system connection.

This makes use of the new method that was added for this.

This sets up default permissions correctly for a connection. When either
configuration indicates we should prefer system connections, KWallet
isn't enabled or we're running a live image we'll try to create a system
connection. However, if we're not allowed to create system connections,
then fall back to creating user connections.

Additionally, this sets the default password storage to store passwords
system-wide if we're creating system-wide connections, since storing
those passwords locally leads to awkward behaviour where a system
connection can't really be reused since the password is not available.

Makes it easier to reuse.

In certain cases, like when using IWD as NetworkManager backend, it is
better to create system connections by default. This adds a
configuration setting  to check if we should create those.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

We generally include such buttons in full-screen overlays so that it's
visually obvious how to close it, for people not familiar with the UX
concept of clicking on the thing itself or its darkened background.

CCBUG: 455950

addAndActivate in some cases will show the connection editor dialog. In
that case, once the dialog is confirmed, we would call "addConnection"
rather than "addAndActivateConnection", so one would need to manually
connect to the now correctly configured network again. Instead, move the
"addAndActivate" dbus call to its own method so we can call it in the
signal handler rather than calling only addConnection.

ValueHistorySource has been deprecated for a while

To close the window by using keyboard.

CCBUG: 455950