Consider connected bridges and VLANs to be connections for icon purposes

Nate Grahamrequested to merge
work/ngraham/correct-icons-for-bridges-and-vlans into master

Currently, bridges and VLANs are not considered real connections for icon lookup purposes, so the code returns a disconnected icon.

Before 5ce273ac, the icon it returned was network-wired-available, which doesn't look disconnected in the Breeze icon theme, so nobody noticed or cared.

5ce273ac changed that to return network-wired-disconnected, which people do notice and care about.

The underlying problem is bridge and VLAN connections not being considered active connections for icon purposes; fixing that results in an icon that is both semantically and visually correct when the only active connections are bridges or VLANs.

Before 5ce273ac: wrong, but nobody cared With 5ce273ac: wrong and noticeable With this MR: finally correct
bridge__wrong__but_not_obviously_so bridge__obviously_wrong bridge__finally_correct

No regressions seen in icon display with normal wired and wireless connections.

BUG: 516712
FIXED-IN: 6.6.2

Edited by Nate Graham

Merge request reports