Skip to content

GitLab

P
Plasma applet for NetworkManager
Commit fa439a4a authored by Jan Grulich's avatar Jan Grulich
Browse files
Options

Revert "802-1x: Add support for EAP-PWD" 

This reverts commit b9833345.

Plasma 5.12 will depend on Frameworks 5.41.
parent f4a1918b
Hide whitespace changes
Inline Side-by-side
Showing with 12 additions and 88 deletions
CMakeLists.txt
View file @ fa439a4a
......@@ -34,7 +34,7 @@ find_package(KF5 REQUIRED
I18n WindowSystem Service Completion WidgetsAddons KIO CoreAddons Wallet ItemViews XmlGui
ConfigWidgets IconThemes Solid DBusAddons Notifications Plasma Declarative Init KDELibs4Support)
find_package(KF5NetworkManagerQt REQUIRED 5.42.0)
find_package(KF5NetworkManagerQt REQUIRED 5.21.0)
find_package(KF5ModemManagerQt 5.14.0)
set_package_properties(KF5ModemManagerQt PROPERTIES
......
libs/editor/settings/security802-1x.cpp
View file @ fa439a4a
......@@ -40,7 +40,6 @@ Security8021x::Security8021x(const NetworkManager::Setting::Ptr &setting, bool w
m_ui->leapPassword->setPasswordOptionsEnabled(true);
m_ui->md5Password->setPasswordOptionsEnabled(true);
m_ui->peapPassword->setPasswordOptionsEnabled(true);
m_ui->pwdPassword->setPasswordOptionsEnabled(true);
m_ui->tlsPrivateKeyPassword->setPasswordOptionsEnabled(true);
m_ui->ttlsPassword->setPasswordOptionsEnabled(true);
......@@ -50,20 +49,18 @@ Security8021x::Security8021x(const NetworkManager::Setting::Ptr &setting, bool w
m_ui->auth->setItemData(0, NetworkManager::Security8021xSetting::EapMethodTls);
m_ui->auth->setItemData(1, NetworkManager::Security8021xSetting::EapMethodLeap);
m_ui->auth->setItemData(2, NetworkManager::Security8021xSetting::EapMethodPwd);
m_ui->auth->setItemData(3, NetworkManager::Security8021xSetting::EapMethodFast);
m_ui->auth->setItemData(4, NetworkManager::Security8021xSetting::EapMethodTtls);
m_ui->auth->setItemData(5, NetworkManager::Security8021xSetting::EapMethodPeap);
m_ui->auth->setItemData(2, NetworkManager::Security8021xSetting::EapMethodFast);
m_ui->auth->setItemData(3, NetworkManager::Security8021xSetting::EapMethodTtls);
m_ui->auth->setItemData(4, NetworkManager::Security8021xSetting::EapMethodPeap);
} else {
m_ui->auth->removeItem(2); // LEAP
m_ui->stackedWidget->removeWidget(m_ui->leapPage);
m_ui->auth->setItemData(0, NetworkManager::Security8021xSetting::EapMethodMd5);
m_ui->auth->setItemData(1, NetworkManager::Security8021xSetting::EapMethodTls);
m_ui->auth->setItemData(2, NetworkManager::Security8021xSetting::EapMethodPwd);
m_ui->auth->setItemData(3, NetworkManager::Security8021xSetting::EapMethodFast);
m_ui->auth->setItemData(4, NetworkManager::Security8021xSetting::EapMethodTtls);
m_ui->auth->setItemData(5, NetworkManager::Security8021xSetting::EapMethodPeap);
m_ui->auth->setItemData(2, NetworkManager::Security8021xSetting::EapMethodFast);
m_ui->auth->setItemData(3, NetworkManager::Security8021xSetting::EapMethodTtls);
m_ui->auth->setItemData(4, NetworkManager::Security8021xSetting::EapMethodPeap);
}
// Set PEAP authentication as default
......@@ -91,8 +88,6 @@ Security8021x::Security8021x(const NetworkManager::Setting::Ptr &setting, bool w
connect(m_ui->leapPassword, &PasswordField::passwordOptionChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->fastAllowPacProvisioning, &QCheckBox::stateChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->pacFile, &KUrlRequester::textChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->pwdUsername, &KLineEdit::textChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->pwdPassword, &PasswordField::textChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->fastUsername, &KLineEdit::textChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->fastPassword, &PasswordField::textChanged, this, &Security8021x::slotWidgetChanged);
connect(m_ui->fastPassword, &PasswordField::passwordOptionChanged, this, &Security8021x::slotWidgetChanged);
......@@ -180,18 +175,6 @@ void Security8021x::loadConfig(const NetworkManager::Setting::Ptr &setting)
} else {
m_ui->leapPassword->setPasswordOption(PasswordField::AlwaysAsk);
}
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodPwd)) {
m_ui->auth->setCurrentIndex(m_ui->auth->findData(NetworkManager::Security8021xSetting::EapMethodPwd));
m_ui->pwdUsername->setText(securitySetting->identity());
if (securitySetting->passwordFlags().testFlag(NetworkManager::Setting::None)) {
m_ui->pwdPassword->setPasswordOption(PasswordField::StoreForAllUsers);
} else if (securitySetting->passwordFlags().testFlag(NetworkManager::Setting::AgentOwned)) {
m_ui->pwdPassword->setPasswordOption(PasswordField::StoreForUser);
} else {
m_ui->pwdPassword->setPasswordOption(PasswordField::AlwaysAsk);
}
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodFast)) {
m_ui->auth->setCurrentIndex(m_ui->auth->findData(NetworkManager::Security8021xSetting::EapMethodFast));
m_ui->fastAnonIdentity->setText(securitySetting->anonymousIdentity());
......@@ -273,8 +256,6 @@ void Security8021x::loadSecrets(const NetworkManager::Setting::Ptr &setting)
m_ui->leapPassword->setText(securitySetting->password());
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodFast)) {
m_ui->fastPassword->setText(securitySetting->password());
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodPwd)) {
m_ui->pwdPassword->setText(securitySetting->password());
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodTtls)) {
m_ui->ttlsPassword->setText(securitySetting->password());
} else if (eapMethods.contains(NetworkManager::Security8021xSetting::EapMethodPeap)) {
......@@ -385,22 +366,6 @@ QVariantMap Security8021x::setting() const
} else {
setting.setPasswordFlags(NetworkManager::Setting::NotSaved);
}
} else if (method == NetworkManager::Security8021xSetting::EapMethodPwd) {
if (!m_ui->pwdUsername->text().isEmpty()) {
setting.setIdentity(m_ui->pwdUsername->text());
}
if (m_ui->pwdPassword->passwordOption() == PasswordField::StoreForAllUsers) {
setting.setPasswordFlags(NetworkManager::Setting::None);
} else if (m_ui->pwdPassword->passwordOption() == PasswordField::StoreForUser) {
setting.setPasswordFlags(NetworkManager::Setting::AgentOwned);
} else {
setting.setPasswordFlags(NetworkManager::Setting::NotSaved);
}
if (!m_ui->pwdPassword->text().isEmpty()) {
setting.setPassword(m_ui->pwdPassword->text());
}
} else if (method == NetworkManager::Security8021xSetting::EapMethodFast) {
if (!m_ui->fastAnonIdentity->text().isEmpty()) {
setting.setAnonymousIdentity(m_ui->fastAnonIdentity->text());
......@@ -615,8 +580,6 @@ bool Security8021x::isValid() const
// TODO Validate other certificates??
} else if (method == NetworkManager::Security8021xSetting::EapMethodLeap) {
return !m_ui->leapUsername->text().isEmpty() && (!m_ui->leapPassword->text().isEmpty() || m_ui->leapPassword->passwordOption() == PasswordField::AlwaysAsk);
} else if (method == NetworkManager::Security8021xSetting::EapMethodPwd) {
return !m_ui->pwdUsername->text().isEmpty() && (!m_ui->pwdPassword->text().isEmpty() || m_ui->pwdPassword->passwordOption() == PasswordField::AlwaysAsk);
} else if (method == NetworkManager::Security8021xSetting::EapMethodFast) {
if (!m_ui->fastAllowPacProvisioning->isChecked() && !m_ui->pacFile->url().isValid()) {
return false;
......
libs/editor/settings/ui/802-1x.ui
View file @ fa439a4a
......@@ -48,11 +48,6 @@
<string>LEAP</string>
</property>
</item>
<item>
<property name="text">
<string>PWD</string>
</property>
</item>
<item>
<property name="text">
<string>FAST</string>
......@@ -303,40 +298,6 @@
</item>
</layout>
</widget>
<widget class="QWidget" name="pwdPage">
<layout class="QFormLayout" name="formLayout_8">
<item row="0" column="0">
<widget class="QLabel" name="label_33">
<property name="text">
<string>Username:</string>
</property>
<property name="buddy">
<cstring>md5UserName</cstring>
</property>
</widget>
</item>
<item row="0" column="1">
<widget class="KLineEdit" name="pwdUsername"/>
</item>
<item row="1" column="0">
<widget class="QLabel" name="label_34">
<property name="text">
<string>Password:</string>
</property>
<property name="buddy">
<cstring>md5Password</cstring>
</property>
</widget>
</item>
<item row="1" column="1">
<widget class="PasswordField" name="pwdPassword">
<property name="passwordModeEnabled" stdset="0">
<bool>true</bool>
</property>
</widget>
</item>
</layout>
</widget>
<widget class="QWidget" name="fastPage">
<layout class="QFormLayout" name="formLayout_4">
<item row="0" column="0">
......@@ -734,16 +695,16 @@
<extends>QComboBox</extends>
<header>kcombobox.h</header>
</customwidget>
<customwidget>
<class>KLineEdit</class>
<extends>QLineEdit</extends>
<header>klineedit.h</header>
</customwidget>
<customwidget>
<class>KUrlRequester</class>
<extends>QWidget</extends>
<header>kurlrequester.h</header>
</customwidget>
<customwidget>
<class>KLineEdit</class>
<extends>QLineEdit</extends>
<header>klineedit.h</header>
</customwidget>
<customwidget>
<class>PasswordField</class>
<extends>QLineEdit</extends>
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment