GitLab

GIT_SILENT

GIT_SILENT

Fushan Wen authored May 07, 2022 and Nate Graham committed May 11, 2022

For device view, use `audio-volume-muted` if there is no output or input
devices. For stream view, use `edit-none` if there is no applications playing
or recording audio.

Whilst we don't use this for anything until explicitly set there'sa
comparator at the top of setTarget which valgrind correctly complains
about.

Move the workaround to use a different sound for the subwoofer test
to C++, so we can still use the `lfe` channel and the `rear-center`
sound file.

Doing otherwise seems to be specially problematic on pipewire

BUG: 445523
FIXED-IN: 5.24.5

Alexandre Pereira authored Apr 19, 2022 and Nate Graham committed Apr 19, 2022

This makes them appear when show is checked and hide when not checked.
The logic before was reversed.

USE_GSETTINGS was always set to TRUE.

Tested by changing settings in pavucontrol and kcm_pulseaudio, the settings
in either of them reflect the other.

Willyanto Willyanto authored Apr 19, 2022 and Nate Graham committed Apr 19, 2022

Currently, both KCM and applet tooltip show mute device or stream even if it
is muted. Add unmute device or stream message in the tooltip if it is muted.

This wasn't tested and it can't possibly work for now because
plasma-framework has no support for Qt6 at the moment.

This reverts commit 57b0485f.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Errors produced when trying to play a sound were being ignored.
Show them in the spaker test UI, so it can help users to find
their cause.

The error strings are provided directly by libcanberra, so i18n
will be probably missing for them.

CCBUG: 451995

Arjen Hiemstra authored Mar 30, 2022 and Nate Graham committed Mar 30, 2022

Virtual devices are generally created by filters and other special
handling. It doesn't usually make sense to show these, especially when
they are vendor-provided. However, there are use cases to have them
visible, so make it configurable.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Nicolas Fella authored Feb 24, 2022 and Nate Graham committed Feb 28, 2022

Otherwise changing the device from e.g. the applet doesn't update the
running KCM

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

GIT_SILENT

With the MouseArea on top, the whole area accepts events in the expanded
view, so you can scroll anywhere to change the volume, not just over the
icon.

BUG: 426646
FIXED-IN: 5.24

Nicolas Fella authored May 22, 2021 and Nate Graham committed Jan 10, 2022

Instead of using the "unknown" icon use a mic/speaker icon.

Same as 0dcc603c but for the KCM.

Nicolas Fella authored May 22, 2021 and Nate Graham committed Jan 10, 2022

type is never defined and we always get a value from the outside

The previous patch missed a few parts