GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENT

Default maximumPercent value of 100. So we can call osd.show() with single argument in Plasma Mobile plasmoid.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Much friendlier to read

The old code was incorrect, calling `rowCount` as though it was a
property, but it was instead a function, so it didn't update as
expected.

This commit adds a `count` property that notifies of changes as expected
to the abstract model as well as the filter model. Now the "Show
inactive devices" buttons should be properly hidden by people whose
audio setup has no hidden devices.

This commit got dropped from
!5 when it
landed, somehow.

Most things can be ported, but tab bar and context menu need to stay
using PC2 for now because:
- PC3 TabBar/TabButton needs a bit of work first
- There's no native PC3 context menu functionality

We've now made it easier to increase the maximum volume to 150% for
those who need it due to quiet speakers. However since this could
potentially lead to excessive volume or damage to loud speakers with
long-term use, let's colorize the text to subtly indicate that this is
not a normal state.

Volumes greater than 100% are not correctly displayed in the OSD. They are capped at 100%. This patch makes use of the new OSD API from plasma-workspace!112 to pass along the maximum volume information

BUG: 422537

Right now devices that have only a single unplugged port are visible in the applet and the KCM.
For all intents and purposes, these devices are useless as they are inactive and unused.
Therefore, let's filter them out so they're not distracting and confusing to the user. An option
to see them all again is provided in the KCM on the off chance that a person needs to configure
the volume or balance of an unused device *before* it's used.

This patch is principally aimed at people using hardware where PulseAudio represents multiple
input and output sources as separate devices rather than separate ports of the same device.
I asked the PA people about this and they said that for certain hardware, it's intentional,
and the correct approach is to filter out the unused devices over here [1]. So, that's what
this patch does.

Thanks to @nicolasfella for his help with getting the initial prototype working!

BUG: 422612

FIXED-IN: 5.20

[1] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/913

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Using Layout.column/row in conjunction with a Repeater causes a tonne of warnings.
Since we have to use two Repeaters (one for label, one for slider),
lay them out top to bottom and specify the number of rows (since GridLayout
isn't smart enough to enforce a column count when in top to bottom mode...)

The default is "locked" volume slider with just one slider as before.
When opening settings with different volumes in some of the channels,
they are unlocked automatically.

Furthermore, when locking channels again, all channels are set back to a uniform volume.
Normally, plasma-pa adjusts volume by keeping the difference between channels in tact,
so means of explicitly assigning all channels in one go is added.

Also, QQC2 `Slider` has an explicit `onMoved` signal which is only fired when the user
explicitly moves the slider. This should remove the need for the convoluted "ignore changes"
property dance that was present before.

GIT_SILENT

GIT_SILENT

Summary:
Converted applet to use the new page component with PlasmoidHeadings for header and footer.

{F8247486}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28996

Summary:
We need one channel to be able to control the volume. This restores D7485 which was broken by D20450 while fixing a different issue.
This patch tries to combine the two by only creating a new channel if none exists and not messing with existing ones.

BUG: 407397

Test Plan: Can control the notification volume in the KCM now. The slider position matches the one in pavucontrol

Reviewers: #plasma, drosca, broulik, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28822

Summary:
Extend configuration knobs for visual feedback by adding separate ones
for output volume, input volume and mute state.

BUG: 363983
FIXED-IN: 5.19.0

Reviewers: #vdg, #plasma, broulik, ngraham, drosca, cblack

Reviewed By: #vdg, #plasma, ngraham, cblack

Subscribers: The-Feren-OS-Dev, cblack, drosca, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28281

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Summary:
Align mute button volume slider.

Slider has 2 pixel offset, caused from wrong slider height.

Test Plan:
Before:
 {F8130865, layout=inline} {F8130846, layout=inline} {F8130847, layout=inline}

After:
{F8134931, layout=inline} {F8134932, layout=inline} {F8134933, layout=inline} {F8134934, layout=inline}

Reviewers: #plasma, #vdg, drosca, ngraham

Reviewed By: #vdg, ngraham

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27645

Summary:
Remove device icon.
Remove separation line between devices and increase spacing.
Use radioboxes for default device selection.
Always allow port selection.
Fix mute tooltip.
Use small spacing instead of default.
Use plasma components 3 instead of qtquick controls 2.
Remove unused imports.

BUG: 417607
CCBUG: 417447
FIXED-IN: 5.19.0

Doesn't depend, but needs D27420 to activate an unavailable port.

Test Plan:
Before:
Was not possible to select an unavailable port.
Combobox could drive the default button out of the layout.
After:
Combobox row appears for devices that have at least two ports.

{F8106609}

Reviewers: #plasma, drosca, ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27422

Summary:
Set content to use available space.
Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.

BUG:416331
BUG:417447

Test Plan:
Open audio settings from kickoff.

Before:
{F8125148}

After:
{F8125149}

Reviewers: #plasma, #vdg, drosca, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27577