GitLab

When a stream is present but not playing anything ("corked"),
show a "paused" icon over the application.

BUG: 398476
FIXED-IN: 5.23.0

GIT_SILENT

GIT_SILENT

GIT_SILENT

PipeWire does not have support for the relevant PulseAudio modules.

See https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/771

module-switch-on-connect is less relevant since PipeWire has this behavior by default.

BUG: 433246

Otherwise it becomes wider if you set a step size of 10%.

Not all streams have an icon associated. Instead of the generic fallback icon at least show one that is related to audio

source-input does not exist in PulseAudio, only sink-input and source-output.

I don't think it breaks anything so it's just cosmetic

These are the same shortcuts as alsamixer.
0 sets volume to 0%.
1 sets volume to 10%.
...
9 sets volume to 90%.
M toggles mute.

Menu button opens the contextmenu.
Enter will click the default device RadioButton.

A later patch will add Arrow Key navigation.

The sink name is technical glibberish whereas the description is actually for human consumption

This matches the behavior in the applet itself

Jumping by a fixed volumeStep has issues as the value is rounded.
65536/100 = 655.36
65536/100*5 = 3276.8
volumeStep = round(3276.8) = 3277

The floor() patch has an easy to test bug when jumping from 100% to
94% instead of 95% since volumeStep is rounded up.
Eg: 65536 => 62259 (-3277) 100% => 94%  (-6%)

The original round() logic also has issues when volume is around:
f(x) = (65536/100) / 2 + (65536/100) * x

amixer sset Master 983 # f(1)=983.04
Eg: 983 => 4260 (+3277) 1% => 7%  (+6%)

This patch adds changeVolumeByPercent(volumeObject, deltaPercent) to
increment any sink or source by a %volume. It also moves the common
code in increaseVolume() and decreaseVolume() into a new function.

BUG: 434769
BUG: 435522
FIXED-IN: 5.21.5

If you want git blame to ignore formatting revisions run:
git config blame.ignoreRevsFile .git-blame-ignore-revs

Sometimes when you increase or decrease the volume using the key on your
keyboard or a global shortcut, it will change by more than the stepSize.
For example when you're at 40% volume and go up when a stepSize of 5%,
sometimes it will change to 46% volume, not 45%.

The reason for this is that the Volume number we get from PulseAudio and
then manipulate is a float. So we have to round it down to avoid
accumulating errors over time. The percentage display function already
rounds, so let's do the same thing in the functions to increase and
decrease the volume.

We should also use Math.floor() rather than Math.round() to ensure
consistency in the values we're using.

BUG: 434769
FIXED-IN: 5.21.4

So you can quickly check e.g. what microphone an app is using.

This is a user-visible message in the documentation.

BUG: 434011

As discussed in https://mail.kde.org/pipermail/plasma-devel/2021-February/119329.html

GIT_SILENT

Makes it more obvious than just changing the icon.

The applet has a special mode where it only shows a user-friendly name
(e.g. "Speakers" and "Microphone") when there is only one device, on the
logic that the full name is not needed when there is only one device
because the user knows what it is, and also depending on the audio
drivers in use, it can be a rather unsightly text string.

However there may be times when the user actually wants to know the full
name; perhaps they have forgotten which device of many they regularly
use is currently connected, for example. For this case, we now display
the full name on hover, so it's not getting in the way and possibly
looking ugly until it's actually needed.

BUG: 433476
FIXED-IN: 5.22

CCBUG: 432482

This moves the menu logic into C++ to make `ListItemBase` less messy.
More importantly, it adds card profile selection so that you can, for instance,
quickly switch Bluetooth devices between A2DP and HFP profiles.
It also now uses radio buttons to denote mutually excusive options.

BUG: 372562
FIXED-IN: 5.22.0

* Don't recrete Ports and Profiles list every time, re-use existing instances
  and add/remove as needed
* Don't emit propertiesChanged when they didn't change
* Some other minor checks

This makes is very easy to mute when you are in the tablet mode
and use the touch/pen input for the interactions.

Considering that left clicking currently does nothing
it should not disrupt anyone's workflow.

`pa_channel_map_equal` returns `1` when equal and `0` when not equal.
We want to update it when it's *not* equal.

This makes it easier to build against both Qt5 and Qt6

GIT_SILENT

This fixes a binding loop and is more correct in general.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The stream list was changed into a `PulseObjectFilterModel` to filter out
virtual streams but there are some places that relied on the `role()` method
on the original model.

Just add a `role()` function calling into the source model.
This fixes the menu on Applications tab not working.

Ideally, we'd just use the enums on the respective model but with the
dynamic way plasma-pa creates those roles, that's difficult.

GIT_SILENT

GIT_SILENT