Skip to content

applet: don't make inactive StackView pages initially visible

Christoph Wolk requested to merge cwo/plasma-pa:properties_not_children into master

Unlike SwipeView, StackView does not automatically add all children as items to the stack; items that are not just exist in the same space as the StackView (often overlapped and hidden by it), but are otherwise still treated like any other item. This means that controls in that item can still receive keyboard focus (e.g. through tab navigation) and can also be activated, even if they are not visible.

A simple way to solve this is to put the two tab contents not directly as children (that are displayed visually), but as properties (that are not displayed unless explicitly added, such as by putting them on the StackView)

Another attempt at solving the problem from !328 (closed), this time fixing the actual problem instead of the symptoms.

I think Qt is doing the correct thing here (see also my comment from that MR), and the applet is wrong. I checked a sample of all the StackViews we have in Plasma (and the apps I have locally), and this particular problem seems limited to this applet. If there's other places where invisible items can receive focus (e.g. bug 500840), I think they're unrelated.

Merge request reports