Skip to content

applet: fix and simplify arrow key navigation

Christoph Wolk requested to merge cwo/plasma-pa:keyboard_focus_fix into master

The arrow key navigation in the applet currently uses a mix of KeyNavigation, keypress handlers, and lots of activeFocus forcing to get focus in the correct place. This is somewhat complex and leads to subtle bugs when activeFocus and the ListView's currentIndex can go out of sync, leading to key presses that seem to do nothing, or even skipping delegates completely.

Instead, we switch to KeyNavigation and ListView's arrow key handling, reserving custom keypress handlers for setting the currentIndex appropriately when switching to a ListView and handle focus through bindings on currentItem. A little care is necessary to avoid having the inactive tab interfere with the KeyNavigation bindings, but this way we can offload most of the logic and solve the buggy behavior.

@broulik I think this should fix it, give it a try if you have the chance.

Merge request reports