Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma PulseAudio Applet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma PulseAudio Applet
  • Merge requests
  • !50

Merged
Created Feb 04, 2021 by Kai Uwe Broulik@broulik🍇Developer

Rewrite ListItem context menu and add card profile selection

  • Overview 13
  • Commits 1
  • Changes 6

This moves the menu logic into C++ to make ListItemBase less messy. More importantly, it adds card profile selection so that you can, for instance, quickly switch Bluetooth devices between A2DP and HFP profiles. It also now uses radio buttons to denote mutually excusive options.

BUG: 372562 FIXED-IN: 5.22.0


@teams/vdg @nicolasfella @sitter @drosca

Overall the menu should behave exactly the same as before with the addition of card profiles.

I've replicated all of the logic from the old menu but there might be something I overlooked, so please test, especially things I didn't test:

  • Port selection
  • HDMI stuff when plugged to a TV
  • and please check some of the TODO/FIXME comments in the code :)

If there's 10 or less profiles (or no other options in the menu), they are shown in the menu directly, otherwise they're put into a "Profiles" submenu. The "off" profile is not offered here as to not let the user remove a device with no obvious way to get it back.

Screenshot_20210203_225113

Edited Feb 04, 2021 by Kai Uwe Broulik
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/kbroulik/new-list-item-menu