Commit b7e93f56 authored by Pino Toscano's avatar Pino Toscano
Browse files

i18n fixes

- translate few UI strings
- use i18np for plural forms
- style fixes
parent 52ecc82b
......@@ -92,7 +92,7 @@ Item {
left: strengthIcon.right
verticalCenter: parent.verticalCenter
}
text: netreg.strength + "% " + netreg.name
text: i18nc("<strength of network>% <network name>", "%1% %2", netreg.strength, netreg.name)
  • Umm. I will revert this small part,

    • It makes no sense to translate either of this
    • There's chance that strength and network name would be empty if ofono is not functional, which results in giant I18N_ARGUMENT_MISSING error..

    If translation is just for percentage part, I want to remove this at one point anyway.

  • This is a UI string, and it ought to be translatable. Even if you plan to change it later, translators ought to choose:

    • how the percentage is displayed, e.g. in case a space is needed between the number and the % character
    • whether the network name should go before or after the percentage, according to the language

    There's chance that strength and network name would be empty if ofono is not functional, which results in giant I18N_ARGUMENT_MISSING error..

    Sigh QML, the code with the unconditional + makes this totally non-obvious. What about the following instead?

    text: netreg.name ? i18nc("<strength of network>% <network name>", "%1% %2", netreg.strength, netreg.name) : i18nc("<strength of network>%", "%1%", netreg.strength)
Please register or sign in to reply
color: PlasmaCore.ColorScope.textColor
font.pixelSize: parent.height / 2
}
......
......@@ -91,7 +91,7 @@ Item {
},
Kirigami.Action {
icon.name: "configure-shortcuts"
text: i18n("Send message")
text: i18n("Send Message")
}
]
......
......@@ -126,7 +126,7 @@ PlasmaCore.ColorScope {
Layout.fillWidth: true
horizontalAlignment: Qt.AlignHCenter
verticalAlignment: Qt.AlignVCenter
text: simManager.pinRetries && simManager.pinRetries[simManager.pinRequired] ? i18n("%1 attempts left", simManager.pinRetries[simManager.pinRequired]) : "";
text: simManager.pinRetries && simManager.pinRetries[simManager.pinRequired] ? i18np("%1 attempt left", "%1 attempts left", simManager.pinRetries[simManager.pinRequired]) : "";
}
RowLayout {
......@@ -187,7 +187,7 @@ PlasmaCore.ColorScope {
top: pad.bottom
horizontalCenter: parent.horizontalCenter
}
text: i18n("Ok")
text: i18n("OK")
onClicked: {
simManager.enterPin(simManager.pinRequired, pinLabel.text)
pinLabel.text = "";
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment