wifi: fix bogus addAndActivateConnection() arg from f8018622

Adam Williamsonrequested to merge
adamwill/plasma-setup:revert-bogus-aac-change into master

Original commit message(s)

  • wifi: fix bogus addAndActivateConnection() arg from f8018622

f8018622 added this extra arg to the addAndActivateConnection() call here which, AFAICT, is simply bogus. I'm fairly sure this is the addAndActivateConnection() from plasma-nm Handler::Handler, which takes exactly three arguments. The original commit seems to have been trying to fix the connection to be system-wide(?), but the commit message gives no indication why the author thought this was the way to do it, and I'm pretty sure it's not.

I suspect this might be the cause of some of the "strange" behavior Brandon Nielsen reported in https://bugzilla.redhat.com/show_bug.cgi?id=2455469#c0 - specifically "3. Password window disappears?" I suspect at that point we hit this bogus call and the ConnectDialog crashed, or something like that. The later steps probably wind up hitting the not-broken addAndActivateConnection() call in main.qml ?

Signed-off-by: Adam Williamson awilliam@redhat.com

(For future reference, follow the guidelines at https://cbea.ms/git-commit/#seven-rules)

Reason for the change

I'm pretty sure this call is just bogus and at least can't possibly work as intended, and more likely blows up entirely. This may be causing buggy behavior.

Test plan

Set up a wifi connection with a password, see if it behaves as expected.

Merge request reports