Skip to content
  • Nate Graham's avatar
    [applets/systemtray] Fix expanded representation's internal margins · 695fec4a
    Nate Graham authored
    Summary:
    This is a pre-existing problem, but became much more visible with D27189 (thus exposing
    one of the reasons why I like visually separating dissimilar elements so much).
    Essentially the dialog's bottom and right margins were not being properly mirrored on
    the top and left, leading to the applet's content view looking off-center. Various apps
    were locally adding their own extra top margins to compensate for this, which can be
    removed once this patch lands.
    
    This patch fixes that by explicitly using the default dialog margins for those edges.
    
    I will submit follow-up patches to fix applets that were adding extra padding that is
    now unnecessary.
    
    Test Plan:
    It was especially noticeable with D27160.
    
    Before: {F8180273}
    
    After: {F8180272}
    
    Reviewers: #vdg, #plasma, cblack
    
    Reviewed By: #vdg, #plasma, cblack
    
    Subscribers: cblack, plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D28089
    695fec4a