Skip to content
  • Fabian Vogt's avatar
    Use QJSValue as method parameter type for the scripting interface · 6e5c9e9b
    Fabian Vogt authored
    Summary:
    If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
    from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
    To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
    is necessary.
    
    I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
    even if it's a bug we'll have to workaround it.
    
    BUG: 397338
    
    Test Plan: I have favorites in kickoff again.
    
    Reviewers: #plasma
    
    Subscribers: plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D14822
    6e5c9e9b