Skip to content
  • David Redondo's avatar
    Fix slideshow crashing in invalidate() · a1cf305f
    David Redondo authored
    Summary:
    QSortFilterProxyModel uses std::stable_sort internally which requires that the
    comparison function generates a strict weak ordering. Returning true or false
    randomly didn't fullfil this requirement causing a crash in some calls to invalidate.
    To keep the random order consistent a vector of row indices is used which records
    the current random order.
    
    BUG: 413018
    FIXED-IN: 5.17.1
    
    Test Plan:
    To reproduce the bug use a slideshow in random order with few pictures and a small
    time intervall.
    
    Reviewers: #plasma, broulik
    
    Reviewed By: #plasma, broulik
    
    Subscribers: davidedmundson, broulik, plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D24723
    a1cf305f