Skip to content
  • Randy Kron's avatar
    Improve quality of images in notifications (Bug 385097) · bfe2539a
    Randy Kron authored and David Edmundson's avatar David Edmundson committed
    Summary:
    BUG: 385097
    FIXED-IN: 5.12.0
    
    This patch to plasma-workspace is to improve the quality of images in notifications as reported in [[ https://bugs.kde.org/show_bug.cgi?id=385097 | Bug 385097 ]].
    
    It is still not perfect because KIO::PreviewJob is used to create the thumbnail, and it only produces two sizes, 128px and 256px, so it is likely that a small image will be scaled up, blurring it somewhat.
    
    I took two screenshots of the same Dolphin window. Here is the before, without the patch:
    {F5665511}
    
    And the after, with the patch:
    {F5665513}
    
    Better, but still not perfect.
    
    Test Plan: Take screenshots with Spectacle with and without the patched libnotificationshelperplugin library and observe the image quality in the notification. plasmashell must be restarted when the library file is changed for it to take effect.
    
    Reviewers: #plasma_workspaces, #plasma, broulik
    
    Reviewed By: #plasma_workspaces, #plasma, broulik
    
    Subscribers: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma
    
    Tags: #spectacle, #plasma
    
    Differential Revision: https://phabricator.kde.org/D9993
    bfe2539a