Skip to content
  • Harald Sitter's avatar
    fix translations kcm to be usable on new users/installations · f1ca0ea4
    Harald Sitter authored and Eike Hein's avatar Eike Hein committed
    Summary:
    this broke somewhat recently. the new availabletranslationsmodel's
    rowcount is always 0 on a completely fresh system with no language
    preference set. this is because the actual available languages list is
    only compiled in its ::setSelectedLanguages function. this function was
    however never called. this resulted in the kcm thinking there are no
    available languages and thus making it impossible to actually add one by
    disabling the button and having an empty view even if the button wasn't
    disabled.
    
    previously this was a single model, from what I can see, and that was
    incorrectly ported. where previously the setSelectedLanguages was only
    called on one model we now need to call it on all models to properly
    propagate the language information.
    
    (the reason it works this way is because available languages kinda need to
     include already selected languages for consistency; even when the kcm
     technically didn't find them available)
    
    Test Plan:
    - make new user
    - start kcm
    - kcm DOES NOT show infobox 'no languages installed' and the add languages button is enabled
    - clicking the button gives a list of languages
    - adding one works as well
    
    Reviewers: sitter
    
    Subscribers: ngraham, plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D15115
    f1ca0ea4