Commit 13aa418c authored by Marco Martin's avatar Marco Martin

get rid of manual window flags setting on controller

Summary:
with Qt 5.9, the panel controller can't get focus, so
it can't be dismissed by clicking anywhere, (couldn't
figure out what was the commit that caused the regression)
removing the manual setting of flags seems to fix it,
while the behavior seems unaltered with Qt 5.7 and 5.8

Test Plan: tested on machines with Qt 5.7, 5.8 and 5.9 installed

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mvourlakos, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6403
parent 5f4333fe
......@@ -58,7 +58,6 @@ PanelConfigView::PanelConfigView(Plasma::Containment *containment, PanelView *pa
[=]() {
setScreen(panelView->screen());
KWindowSystem::setType(winId(), NET::Dock);
setFlags(Qt::WindowFlags((flags() | Qt::FramelessWindowHint | Qt::WindowStaysOnTopHint) & (~Qt::WindowDoesNotAcceptFocus)));
KWindowSystem::setState(winId(), NET::KeepAbove);
syncGeometry();
syncLocation();
......@@ -66,7 +65,6 @@ PanelConfigView::PanelConfigView(Plasma::Containment *containment, PanelView *pa
KWindowSystem::setType(winId(), NET::Dock);
KWindowSystem::setState(winId(), NET::KeepAbove);
setFlags(Qt::WindowFlags((flags() | Qt::FramelessWindowHint | Qt::WindowStaysOnTopHint) & (~Qt::WindowDoesNotAcceptFocus)));
KWindowSystem::forceActiveWindow(winId());
KWindowEffects::enableBlurBehind(winId(), true);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment